chore: remove shadcn registry and use relative imports #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
benlife5
reviewed
Jan 30, 2026
packages/visual-editor/src/components/categories/AdvancedCoreInfoCategory.tsx
Outdated
Show resolved
Hide resolved
packages/visual-editor/src/components/footer/ExpandedFooter.tsx
Outdated
Show resolved
Hide resolved
benlife5
reviewed
Jan 30, 2026
| "docs:preview": "vitepress preview .", | ||
| "generate-registry": "tsx src/components/registry/build-registry.cts", | ||
| "build-registry-docs": "pnpm run docs:build && pnpm run generate-registry", | ||
| "i18n:insert": "pnpm exec tsx scripts/insertI18n.ts", |
Contributor
There was a problem hiding this comment.
I think you can also get rid of packages/visual-editor/artifacts.json, packages/visual-editor/config.yaml, packages/starter/components.json and the scripts.components entry in packages/starter/package.json
Contributor
There was a problem hiding this comment.
Oh wait I guess artifacts and config.yaml power the documentation site too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the component registry was a neat idea, no one used it in practice. We're also limiting hybrid functionality at this point.