Skip to content

check if values from json are used #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bernt-matthias wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

check if values from json are used #30

bernt-matthias wants to merge 1 commit into from

Conversation

@bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Jul 9, 2024 •
edited
Loading

or default from Options

@bernt-matthias
check if values from json are used
22453dd 
of default from Options
@bernt-matthias bernt-matthias marked this pull request as draft July 9, 2024 08:02
@bernt-matthias
Copy link
Contributor Author

bernt-matthias commented Jul 9, 2024

This shows that only the default is used and not the config file specified on the CLI

@bernt-matthias bernt-matthias requested a review from mai00fti July 10, 2024 12:39
@bernt-matthias
Copy link
Contributor Author

bernt-matthias commented Jul 10, 2024

@soulios can you please double check this: it seems that the traindmpnn (in the master branch) does only use the defaults from the data classes and not the values from the json input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mai00fti mai00fti Awaiting requested review from mai00fti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bernt-matthias