Skip to content

fix: prevent Maximum call stack size exceeded in asyncSerialArray #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vbin-dev wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −4
Open

fix: prevent Maximum call stack size exceeded in asyncSerialArray #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const formatRegExp = /%[sdj%]/g;

declare var ASYNC_VALIDATOR_NO_WARNING;

export let warning: (type: string, errors: SyncErrorType[]) => void = () => {};
export let warning: (type: string, errors: SyncErrorType[]) => void = () => { };

// don't print warning message when in production env or node runtime
if (
Expand Down Expand Up @@ -155,7 +155,11 @@ function asyncSerialArray(
const original = index;
index = index + 1;
if (original < arrLength) {
func(arr[original], next);
func(arr[original], function (errors) {
queueMicrotask(() => {
next(errors);
})
});
} else {
callback([]);
}
Expand Down Expand Up @@ -229,8 +233,8 @@ export function asyncMap(
callback(results);
return results.length
? reject(
new AsyncValidationError(results, convertFieldsError(results)),
)
new AsyncValidationError(results, convertFieldsError(results)),
)
: resolve(source);
}
};
Expand Down