🏛️Product base types: add support to loaders#1301
Merged
Conversation
antirotor
added
the
type: enhancement
2 tasks
antirotor
added
the
sponsored
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling product base types in loader plugins, allowing loader plugins to declare compatibility with specific product base types.
- Added a new attribute "product_base_types" to loader plugins.
- Updated the compatibility-check logic to consider both product types and product base types.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…pes-support-in-loading' into enhancement/1294-product-base-types-support-in-loading
iLLiCiTiT
reviewed
Jun 13, 2025
iLLiCiTiT
reviewed
Jun 13, 2025
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
reviewed
Jun 16, 2025
iLLiCiTiT
reviewed
Jun 16, 2025
iLLiCiTiT
reviewed
Jun 16, 2025
iLLiCiTiT
approved these changes
Jun 19, 2025
github-project-automation
bot
moved this from Review In Progress
to Merge Requested
in PR reviewing
iLLiCiTiT
reviewed
Jun 19, 2025
iLLiCiTiT
reviewed
Jun 19, 2025
iLLiCiTiT
reviewed
Jun 19, 2025
iLLiCiTiT
reviewed
Jun 19, 2025
iLLiCiTiT
reviewed
Jun 19, 2025
iLLiCiTiT
reviewed
Jun 19, 2025
iLLiCiTiT
reviewed
Jun 19, 2025
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
…roduct-base-types-support-in-loading
iLLiCiTiT
reviewed
Jun 20, 2025
iLLiCiTiT
reviewed
Jun 20, 2025
iLLiCiTiT
reviewed
Jun 24, 2025
Comment on lines
145
to
146
| and not plugin_product_filter | ||
| and not cls.extensions |
Member
There was a problem hiding this comment.
Suggested change
| and not plugin_product_filter | |
| and not cls.extensions | |
| or not plugin_product_filter | |
| or not cls.extensions |
iLLiCiTiT
deleted the
enhancement/1294-product-base-types-support-in-loading
branch
github-project-automation
bot
moved this from Review In Progress
to Done
in PR reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add support for product base type to loader plugins. Loaders can define compatibility with specific product base types.
Additional info
This shouldn't change any existing functionality until implemented in individual loaders.
Note
Requires: ynput/ayon-python-api#255
Requires: ynput/ayon-backend#615
Closes: #1294
Warning
For loading using product base types, you need to publish something using product base type first.
Because #1296 isn't implemented yet, you need to do it using REST API (do it directly and not via publisher).It is implemented by #1315Testing notes:
For testing and more information, follow description here: #1297