🏛️Product base types: Make use of product base#393
Closed
🏛️Product base types: Make use of product base#393
Conversation
antirotor
added
type: enhancement
Member
|
Replaced by #396 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add support for product base types. Change the current usage of product type, add settings and conversion methods.
Additional review information
This PR requires future version of ynput/ayon-core with proper support (most likely 1.9.0)
Testing notes:
Without compatible version of ayon-core, this won't work. With it, everything should work as before plus it should set properly
product_typeif set using creator settings.