feat(loaders): emit internal event when sources are loaded#67
Merged
Conversation
Add "ayon-source-loaded" internal event dispatch to FramesLoader and MovLoader after successfully loading content. This enables other components to react when new sources are loaded into OpenRV. Signed-off-by: philippe-ynput <philippe@ynput.io>
Contributor
|
Although this may work for explicitly loaded content, and I somewhat like it - but the review session from the web will open rv with Is there no way we can just respond to new nodes being created or sources being loaded in a generic fashion? |
Contributor
Author
|
This case is the easy one and we take the easy route. When a node is loaded through OTIO, we already listen to a signal emitted when a new source node is created. There, I will check if OTIO metadata is present, update the node's ayon metadata with it and call for an update. That will be my next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add "ayon-source-loaded" internal event dispatch to FramesLoader and MovLoader after successfully loading content. This enables other components to react when new sources are loaded into OpenRV.
Additional review information
None
Testing notes: