Skip to content

Operations: Better error message #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iLLiCiTiT merged 2 commits into from
Jan 23, 2025
Merged

Operations: Better error message #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04585d2
better error message if operations fail
iLLiCiTiT Jan 23, 2025
d432a12
added 'ok' property to response
iLLiCiTiT Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ayon_api/server_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,12 @@ def detail(self):
def status_code(self) -> int:
return self.status

@property
def ok(self) -> bool:
if self._response is not None:
return self._response.ok
return False

def raise_for_status(self, message=None):
if self._response is None:
if self._data and self._data.get("detail"):
Expand Down Expand Up @@ -8971,8 +8977,11 @@ def _send_batch_operations(

op_results = result.get("operations")
if op_results is None:
detail = result.get("detail")
if detail:
raise FailedOperations(f"Operation failed. Detail: {detail}")
raise FailedOperations(
"Operation failed. Content: {}".format(str(result))
f"Operation failed. Content: {result.text}"
)

if result.get("success") or not raise_on_fail:
Expand Down
Loading