-
Notifications
You must be signed in to change notification settings - Fork 34
Added new things and fixed bugs #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
chickemeeple
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions are working great, thank you.
I don't think the run.sh and run.bat are really necessary.
yep, run.sh and run.bat are just interactive menu( btw,not done yet) removed |
idk why some of words isn't translated in game
|
idk why some parts can't be translated in game |
|
There is a small bug I found in "raid" flag in /spawnmob : |
I found that when we do $getBuildingType(playername), it didn't return anything, so i fixed it
|
Be able to directly toggle the mode on or off... |
… event mobs never despawn bug
this bug fixed |
don't use "/spawnmob ...raid:true" and "/event" together... |
This reverts commit 935a44f.
# Conflicts: # packages/junon-io/client/main.ejs # packages/junon-io/server/entities/event_handler.js
… they are no longer needed
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…/ allowed miamsa in peaceful mode
|
idk the bug( sometimes when players join sectors just seeing sky) is fixed or not. |
|
Dear @simpleyuji , I’d really appreciate it if you could review and accept my pull request. My minigame depends on it and can’t be completed otherwise. Thank you!🫡 |
|
For $getBuildingType, I'd say leaving it the same is better, as there are command blocks which may depend on it being null. If not, it's not super useful, as generally building ids are used in this function, and are known building ids. What I'd suggest is having a broader, higher-level function called something like $getEntityType, which returns 'building', 'player', etc. |
|
/spectate also works. One thing though, is any admin can spectate anyone, even in survival/hardcore. I would suggest getting rid of this, so that only owners and players with command access can use this. However it would be fine if it was added as it is |
|
What is the use of the owner flag in projectile? While spawning projectiles, I found no difference whatsoever |
|
There is also a bug where sometimes the mob just sits there and doesn't attack the building. Other times it does attack. |
chickemeeple
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, fix the things I mentioned above, and it should be good.
Thanks for suggestion. I will add $getEntityType , not changing $getBuildingType. |
need type "/projectile [projectile] [row] [col] owner:[entityId]" |
wdym? |
ik how it happened now (not only happen here |
No description provided.