Skip to content

Conversation

@notjc821
Copy link
Contributor

No description provided.

Copy link
Collaborator

@chickemeeple chickemeeple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions are working great, thank you.

I don't think the run.sh and run.bat are really necessary.

@notjc821
Copy link
Contributor Author

notjc821 commented Jul 25, 2025

The functions are working great, thank you.

I don't think the run.sh and run.bat are really necessary.

yep, run.sh and run.bat are just interactive menu( btw,not done yet) removed

@notjc821 notjc821 requested a review from chickemeeple July 27, 2025 03:25
@notjc821
Copy link
Contributor Author

idk why some parts can't be translated in game

@notjc821
Copy link
Contributor Author

There is a small bug I found in "raid" flag in /spawnmob :
After my test....
If you are in sandbox mode and you spawn mobs with raid:true flag , original raid event mobs will never despawn.
Fortunately, this won't happen in survival/horcore mode,
(idk if there will be more bugs, but it seems no)

notjc821 added 3 commits July 29, 2025 10:32
I found that when we do $getBuildingType(playername), it didn't return anything, so i fixed it
@notjc821
Copy link
Contributor Author

notjc821 commented Aug 1, 2025

Be able to directly toggle the mode on or off...
The permission check test hasn't been performed yet, since dev mode has no permission restrictions, making it impossible to test! However, from a logical standpoint, it should work properly, and the functionality itself is working as expected.

@notjc821
Copy link
Contributor Author

notjc821 commented Aug 1, 2025

There is a small bug I found in "raid" flag in /spawnmob : After my test.... If you are in sandbox mode and you spawn mobs with raid:true flag , original raid event mobs will never despawn. Fortunately, this won't happen in survival/horcore mode, (idk if there will be more bugs, but it seems no)

this bug fixed

@notjc821
Copy link
Contributor Author

notjc821 commented Aug 1, 2025

There is a small bug I found in "raid" flag in /spawnmob : After my test.... If you are in sandbox mode and you spawn mobs with raid:true flag , original raid event mobs will never despawn. Fortunately, this won't happen in survival/horcore mode, (idk if there will be more bugs, but it seems no)

don't use "/spawnmob ...raid:true" and "/event" together...
It may cause bug...

@notjc821

This comment was marked as resolved.

@notjc821

This comment was marked as resolved.

@notjc821 notjc821 changed the title Added more funtions and something else Added new things and fixed bugs Aug 4, 2025
@notjc821
Copy link
Contributor Author

notjc821 commented Aug 5, 2025

idk the bug( sometimes when players join sectors just seeing sky) is fixed or not.
cause I tested it in local ,no delaying

@notjc821
Copy link
Contributor Author

notjc821 commented Aug 7, 2025

Dear @simpleyuji , I’d really appreciate it if you could review and accept my pull request. My minigame depends on it and can’t be completed otherwise. Thank you!🫡

@chickemeeple
Copy link
Collaborator

For $getBuildingType, I'd say leaving it the same is better, as there are command blocks which may depend on it being null. If not, it's not super useful, as generally building ids are used in this function, and are known building ids. What I'd suggest is having a broader, higher-level function called something like $getEntityType, which returns 'building', 'player', etc.

@chickemeeple
Copy link
Collaborator

/spectate also works. One thing though, is any admin can spectate anyone, even in survival/hardcore. I would suggest getting rid of this, so that only owners and players with command access can use this. However it would be fine if it was added as it is

@chickemeeple
Copy link
Collaborator

What is the use of the owner flag in projectile? While spawning projectiles, I found no difference whatsoever

@chickemeeple
Copy link
Collaborator

There is also a bug where sometimes the mob just sits there and doesn't attack the building. Other times it does attack.

Copy link
Collaborator

@chickemeeple chickemeeple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, fix the things I mentioned above, and it should be good.

@notjc821
Copy link
Contributor Author

notjc821 commented Aug 8, 2025

For $getBuildingType, I'd say leaving it the same is better, as there are command blocks which may depend on it being null. If not, it's not super useful, as generally building ids are used in this function, and are known building ids. What I'd suggest is having a broader, higher-level function called something like $getEntityType, which returns 'building', 'player', etc.

Thanks for suggestion. I will add $getEntityType , not changing $getBuildingType.

@notjc821
Copy link
Contributor Author

notjc821 commented Aug 8, 2025

What is the use of the owner flag in projectile? While spawning projectiles, I found no difference whatsoever

need type "/projectile [projectile] [row] [col] owner:[entityId]"
And I tested it before, it should work

@notjc821
Copy link
Contributor Author

notjc821 commented Aug 8, 2025

There is also a bug where sometimes the mob just sits there and doesn't attack the building. Other times it does attack.

wdym?
I haven't seen that before, but I will try to fix it.

@notjc821
Copy link
Contributor Author

notjc821 commented Aug 8, 2025

There is also a bug where sometimes the mob just sits there and doesn't attack the building. Other times it does attack.

wdym? I haven't seen that before, but I will try to fix it.

ik how it happened now (not only happen here
when a mob(Ex. chemist) is targeting you, then you run into sky, and it cannot hit you( just standing there and seeing you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants