feat: add 'frame_delay' to stats #55
Draft
+232
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new stream stats endpoint which can be used to retrieve the fps metrics in a way that doesn't affect performance.
This commit ensures that the paths are also available under the `live` prefix. This will allow consistency with the hosted experience and improve the user experience.
This commit improves the naming of the parameters that are used in the fps calculation to ensure they are more descriptive.
This commit ensures that the video stream reference is removed from the app's `video_tracks` object when a stream ends, preventing potential memory leaks, incorrect data and ensuring proper cleanup.
This commit adds the frame delay between the processing time and the expected presentation time to the `/stats` endpoints.
rickstaa
force-pushed
the
add_frame_delay_metric
branch
from
b945133 to
0b4a297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the frame delay between the processing time and the expected presentation time to the
/statsendpoints.Current implementation
I calculate the delay between the expected presentation time and the processing time to get a metric for frame delay. This metric will be returned in the stats endpoint that was implemented in #48. It does not take the roundtrip time into account so it does not reflect full perceived latency. The response of the endpoitn will look like this:
{"913cf9e4-ab7d-4d4a-804f-5922793f5410": {"fps": 13.998930775037604, "frame_delay": 59.76668844101066}}Important
Merge after #48.