Skip to content

Conversation

@backkem
Copy link
Contributor

@backkem backkem commented Jan 28, 2026

Summary

  • Moves duplicated encode_type_key and decode_type_key functions from openscreen-application and openscreen-network into openscreen-common.
  • Both crates now import from the shared module.

Closes #15

@gemini-code-assist
Copy link

Summary of Changes

Hello @backkem, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request centralizes common utility functions, specifically encode_type_key and decode_type_key, into a shared openscreen-common crate. This refactoring effort aims to reduce code duplication across different modules and improve the overall maintainability and consistency of the codebase.

Highlights

  • Code Refactoring: The encode_type_key and decode_type_key functions, previously duplicated in openscreen-application and openscreen-network, have been moved to the openscreen-common crate.
  • Dependency Update: Both openscreen-application and openscreen-network crates now import these shared utility functions from the centralized openscreen-common module, reducing code duplication.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a solid refactoring that successfully moves duplicated encode_type_key and decode_type_key functions into the openscreen-common crate, which improves code reuse and maintainability. The consuming crates are updated correctly. I have one suggestion for the newly added type_key.rs file to optimize stack usage, which is particularly relevant in no_std environments.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@kaidokert kaidokert merged commit 820296f into youtube:main Jan 30, 2026
4 checks passed
@kaidokert
Copy link
Member

Thanks for the quick follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move encode/decode type key functions to openscreen-common

2 participants