Minor refactor renderer #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor refactor to improve readability and extendability (e.g. for a TOCRenderer), inspired by original source https://stackoverflow.com/a/33778564/1680728 who quotes https://gist.github.com/davidjrice/3014948 .
Contributor
Author
|
If this would to be merged, the README needs modification (now in order to override the redcarpet options, the initializer will look different (better). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract options and renderer initialization.
This allows users to easier override just the redcarpet options (#5 ) and possible future implementations of using other renderers (#6).
This is a minor refactor to improve readability and extendability (e.g. for
a TOCRenderer), inspired by original source
https://stackoverflow.com/a/33778564/1680728 who quotes
https://gist.github.com/davidjrice/3014948 .