Conversation
|
Note that this depends on zaproxy/zap-extensions#6640 |
kingthorin
left a comment
kingthorin
left a comment
There was a problem hiding this comment.
Just one thing, otherwise seems fine to me.
| run: | | ||
| cd zaproxy-website | ||
|
|
||
| # Update the index to be sure git is aware of changes | ||
| git update-index -q --refresh | ||
| ## If there are changes: comment, commit, PR | ||
| if ! git diff-index --quiet HEAD --; then | ||
|
|
||
| git add site/data/scans/wavsep/* | ||
| git commit -s -m "Updated WAVSEP Results" | ||
| git push origin | ||
|
|
||
| echo ${{ secrets.ZAPBOT_TOKEN }} | gh auth login --with-token | ||
| gh pr create --fill | ||
|
|
||
| fi |
There was a problem hiding this comment.
IMHO it should update existing, like: #240 or the Auth tests job.
There was a problem hiding this comment.
But without failing the build.
There was a problem hiding this comment.
I wasn't able to come up with a solution to that yet. In the other PR we had agreed to go ahead without that for now.
Not to deter you @psiinon if you see or find a way to do it without failure then go for it.
There was a problem hiding this comment.
Yes, but because the other jobs are either disabled or don't raise PRs as often. This one is yet to be seen.
There was a problem hiding this comment.
As for the solution, we could use an action which gives full control on the behaviour, also allows to remove all the duplication (e.g. https://github.com/zaproxy/zaproxy-website/tree/main/.github/actions/update-website).
There was a problem hiding this comment.
Can I suggest we leave that to a future PR? 😁
Right now this is only being done on demand, and I suspect we'll need to go through a few itterations before we want to automate it...
|
Just deleted the "old" wavsep scanning files as well |
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
|
And 2 crontab files, 1 of which referenced the old wavsep files. Neither have been used for years! |
|
Thank you! |
3 participants
Automation for zaproxy/zaproxy-website#3184