Image download challenge - Platform enginner 2 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About You
Name: Marcelo Aimone
Email: mbaymone@gmail.com
Whatsapp: + 39 339 818 5949
Linkedin: https://www.linkedin.com/in/marceloaymone
About your solution
I've started the project using the proposed quick start and libs, also I've included Winston for logging and Eslint.
Your findings
I had some trouble with Axios and tried to use the max content length config to control the image size, but, in the end, I've used the response header to calculate the image size and control the flow.
To solve the backpressure on request/write, I've used the node stream to write the image content inside promises.
How to run your code?
I've included instructions on readme