Skip to content

Conversation

@kel-gar
Copy link

@kel-gar kel-gar commented Mar 27, 2019

Hey Jen,

Here is my take-home ROI calculator exercise, thank you for your patience. I love what React can do and I had fun refactoring this application by building components that are reusable, easier to read and maintain with destructuring and by not duplicating code in the tables. Also, I put the seed data in its own file which is better practice than hard-coding data into a component.

Pros and Cons of the original application:

Pros- it's a quick app, it accomplishes the goal, it's all in one file

Cons- Too many lines of code, it's hard to read and maintain, code is duplicated, seed data is in the component instead of an external file

I look forward to hearing from you!

Thanks!

Kelly

@kel-gar
Copy link
Author

kel-gar commented Mar 27, 2019

Oh, I still want to make the term dynamic, but feel like I was taking too long as is, so I'll work on that so I know how to implement it for future use. Thanks!

@jen-zayo
Copy link
Contributor

jen-zayo commented Apr 1, 2019

Thanks @kel-gar - We'll take a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants