Skip to content

compatibility with jsonform#2

Open
fuhrysteve wants to merge 8 commits intozbyte64:masterfrom
MontmereLimited:master
Open

compatibility with jsonform#2
fuhrysteve wants to merge 8 commits intozbyte64:masterfrom
MontmereLimited:master

Conversation

@fuhrysteve
Copy link

Thanks for this great, handy little library. I can't imagine you'd want to accept this pull request as-is, since it breaks backwards compatibility pretty severely..

If you have any suggestions, however, for how to accomplish what I'm trying to do here in a more flexible way (I'm essentially rendering a more complete json-schema output), then let me know (presuming this project is still active).

In any case, this seems to accomplish what I'm looking to do and will work just fine for me.

Thanks!

@zbyte64
Copy link
Owner

zbyte64 commented Oct 15, 2017

Your explicit matching of field classes is the proper way forward imho. If there are more projects like wtforms_components that would make sense to integrate with then we would want a module folder with an import for each integration. As for flexibility, conversions could allow for callables to be registered as well as dictionaries. When it comes across a callable, it will be called with the field being converted and the return will be treated as attributes to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants