QRZ(): remove code for disabling SSL verification#10
Open
jj1bdx wants to merge 1 commit intozebpalmer:masterfrom
Open
QRZ(): remove code for disabling SSL verification#10jj1bdx wants to merge 1 commit intozebpalmer:masterfrom
jj1bdx wants to merge 1 commit intozebpalmer:masterfrom
Conversation
Rationale: In HTTPS access for qrz.com, the host should always be verified by the TLS/SSL certificate. Implementation details: * Python `requests` package uses `urllib3` * In many cases using `urllib3` include importing `certifi` * By importing certifi, you're ready to verify the TLS/SSL certificate See <https://urllib3.readthedocs.io/en/latest/user-guide.html#certificate-verification> for the further details.
Author
|
See also a978358#commitcomment-43958444 for the warning message I've got on a Python 3.9 running on macOS 10.14.6. |
|
@zebpalmer , can you please merge this PR when you get the chance? I'm getting tons of unverified HTTPS warnings as well. |
|
@zebpalmer a small ping here. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
In HTTPS access for qrz.com, the host should always be verified by the TLS/SSL certificate.
Implementation details:
requestspackage usesurllib3urllib3include importingcertifiSee https://urllib3.readthedocs.io/en/latest/user-guide.html#certificate-verification for the further details.