title_bar: Respect Linux titlebar config#47506
Open
mufeedali wants to merge 10 commits intozed-industries:mainfrom
Open
title_bar: Respect Linux titlebar config#47506mufeedali wants to merge 10 commits intozed-industries:mainfrom
mufeedali wants to merge 10 commits intozed-industries:mainfrom
Conversation
cla-bot
bot
added
the
cla-signed
zed-community-bot
bot
added
the
first contribution
mufeedali
force-pushed
the
titlebar-config
branch
3 times, most recently
from
53d4d14 to
0d25dcf
Compare
mufeedali
changed the title
maxdeviant
changed the title
Also allows overriding via `title_bar.button_layout` Closes zed-industries#46512
mufeedali
force-pushed
the
titlebar-config
branch
from
d093fbc to
befc54f
Compare
Author
|
I need to re-think some stuff here. I might have made some fundamental mistakes. |
Take your time, hope to see this merged :) |
Author
|
@pfanzola thanks! should be ready now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Zed always places three fixed window buttons (Minimize, Maximize and Close) on the right side of the window in a fixed order ignoring any user configuration or desktop environment preference (like elementary).
This PR adds support for GNOME-style layout strings (
minimize:close). By default, we pull it from the gsettings portal, but we also allow manual configuration viatitle_bar.button_layoutconfig key.Closes #46512
I know it's a relatively large PR for my first one and I'm new to Rust. So, sorry if I've made any huge mistakes. I had just made it for personal use and then decided to try to clean it up and submit it.
I've tested with different configs on Linux. Untested on other platforms, but should have no impact.
If it's not up to par, it's okay, feel free to close :)
Release Notes: