usb: add uevent path #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-zededa
commented
Jan 16, 2026
christoph-zededa
commented
- expose uevent path to the consumer of the library
- allow filtering usb devices by uevent path this is useful when listening to uevents and using ghw library to get the usb device
1. expose uevent path to the consumer of the library 2. allow filtering usb devices by uevent path this is useful when listening to uevents and using ghw library to get the usb device Signed-off-by: Christoph Ostarek <christoph@zededa.com>
europaul
reviewed
Jan 19, 2026
| } | ||
| } | ||
|
|
||
| func WithUSBUeventPath(path string) Option { |
There was a problem hiding this comment.
I don't see how and where this is used...
There was a problem hiding this comment.
Also it seems weird to add this as an option for all device classes
Author
There was a problem hiding this comment.
It is used here: https://github.com/christoph-zededa/eve/blob/usbmanager_use_ghw/pkg/pillar/cmd/usbmanager/scanusb.go#L97
Also it seems weird to add this as an option for all device classes
I thought the same, but then I saw https://github.com/zededa/ghw/blob/main/pkg/option/option.go#L153
|
Does it maybe make sense to upstream it right away? |
Author
I think some discussion will be necessary, so it might take a while until it is merged. |
europaul
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.