Conversation
Byte compiling the file in emacs25 generated a number of warnings, most due the use of obsolete functions, one due to use of an obsolete library, and one due to a face being used as a variable. One of the warnings, about the use function `toggle-read-only', I wasn't sure how to solve because I wasn't sure what the function was exactly doing. Here are the compile warnings: post.el:275:1:Warning: cl package required at runtime In post-font-lock-syntactic-face-function: post.el:675:1:Warning: reference to free variable ‘post-signature-text-face’ In post-el-random-signature: post.el:868:13:Warning: Use ‘with-current-buffer’ rather than save-excursion+set-buffer post.el:855:20:Warning: ‘insert-file’ is for interactive use only; use ‘insert-file-contents’ instead. post.el:856:20:Warning: ‘beginning-of-buffer’ is for interactive use only; use ‘(goto-char (point-min))’ instead. In post-select-signature-from-file: post.el:882:4:Warning: ‘insert-file’ is for interactive use only; use ‘insert-file-contents’ instead. In post-select-signature-from-dir: post.el:926:18:Warning: ‘toggle-read-only’ is an obsolete function (as of 24.3); use ‘read-only-mode’ instead. In post-select-signature-select-sig-from-dir: post.el:941:17:Warning: ‘insert-file’ is for interactive use only; use ‘insert-file-contents’ instead. In post-mode: post.el:1123:9:Warning: ‘flet’ is an obsolete macro (as of 24.3); use either ‘cl-flet’ or ‘cl-letf’. post.el:1137:7:Warning: ‘not-modified’ is for interactive use only; use ‘set-buffer-modified-p’ instead. In header-references-length: post.el:1326:66:Warning: ‘interactive-p’ is an obsolete function (as of 23.2); use ‘called-interactively-p’ instead.
1] Set the signature select buffer to read-only mode also in function `post-select-signature-from-file' 2] Replace use of the obsolete function `toggle-read-only' with function `read-only-mode'
evaluation of exit function needs to be made at runtime
|
Thank you so much for these cleanups! As it is these are a bit hard to review since a lot the pull requests mix up different changes. Would it be possible to separate the changes into more logical pieces? |
|
I've found it difficult to work with git. It seems what I ended up doing was creating subsequent branches of my master instead of creating subsequent branches of your master. At this point, the work is more than three weeks old, so I've forgotten everything I did. The good news is that I can report no problems using the code for all my emails these past weeks. It is a mess in terms of branches, but the good news is that the developments were linear and the commits have descriptions. I don't know enough about using git to know at this point how to go back and change the how the entries are organized. It's not like this VCS has simple text files that could be directly edited and manipulated (AFAIK). It seems that the earliest pull request (#2) is the one with the most comprehensive list of the commit history, not this one, but even that I can't be sure, because I don't have a tool to visualize the tree (something like emacs undo-tree). |
2 participants
No description provided.