Skip to content

Fix: Format thread_ts parameter for proper Slack API thread replies #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonber wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Format thread_ts parameter for proper Slack API thread replies #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,21 @@ export class SlackClient {
};
}

/**
* Format thread_ts to ensure it has the decimal point in the correct position
* Slack expects format like "1234567890.123456" (timestamp with period before last 6 digits)
*/
private formatThreadTs(thread_ts: string): string {
if (!thread_ts.includes('.')) {
// If no period, add it so that 6 digits come after it
if (thread_ts.length >= 7) {
const insertPosition = thread_ts.length - 6;
return thread_ts.slice(0, insertPosition) + '.' + thread_ts.slice(insertPosition);
}
}
return thread_ts;
}

async getChannels(limit: number = 100, cursor?: string): Promise<any> {
const predefinedChannelIds = process.env.SLACK_CHANNEL_IDS;
if (!predefinedChannelIds) {
Expand Down Expand Up @@ -131,7 +146,7 @@ export class SlackClient {
headers: this.botHeaders,
body: JSON.stringify({
channel: channel_id,
thread_ts: thread_ts,
thread_ts: this.formatThreadTs(thread_ts),
text: text,
}),
});
Expand Down Expand Up @@ -177,7 +192,7 @@ export class SlackClient {
async getThreadReplies(channel_id: string, thread_ts: string): Promise<any> {
const params = new URLSearchParams({
channel: channel_id,
ts: thread_ts,
ts: this.formatThreadTs(thread_ts),
});

const response = await fetch(
Expand Down