古い内部用クラスの削除 #10
Merged
古い内部用クラスの削除 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnsnodnb
reviewed
Nov 15, 2024
shodo/lint.py
Outdated
| @@ -1,4 +1,5 @@ | |||
| import time | |||
| from enum import Enum | |||
Member
There was a problem hiding this comment.
from datetime import datetime の下にお願いします！
shodo/aio/lint.py
Outdated
| status = LintStatus.PROCESSING.value | ||
| pause = 0.25 | ||
| while status == Lint.STATUS_PROCESSING: | ||
| while status == LintStatus.PROCESSING: |
Member
There was a problem hiding this comment.
これだと1ループ目で False になって抜けちゃいますね。
Suggested change
| while status == LintStatus.PROCESSING: | |
| while status == LintStatus.PROCESSING.value: |
下の
if status == LintStatus.FAILED.value:のところもお願いします。
もしくは LintResultResponse を生成するタイミングで status: str を status: LintStatus に変更して .value で比較しなくても良いようにするのも良いかと思います
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
クラスで実装されていた古い
Lintの削除です。内部的にのみ使っていたクラスなので今後不要になります。モジュールとしてのAPIを考えると複数あると美しくないため、関数に統一します。使われるべき外部向けの関数としては、
lint()かapi.lint_create()とします。