Add a signal readout for the nearest repeater. With improvements to app bar and other UI polish. by wel97459 · Pull Request #200 · zjs81/meshcore-open

wel97459 · 2026-02-20T03:31:30Z

Adds a signal readout for the nearest repeater along with a list of the rest.
Improvements to app bar to help with consistency.
Message path numbered in the direction of 1 being the closest you it origin.
Improvements to the path management. It now sorts the paths and only show paths with a starting hop of one of the repeaters in the nearest repeater list.

- Added error handling and logging to the Cayenne LPP parsing methods to manage malformed data gracefully. - Improved the structure of the parsing logic for better readability and maintainability. - Updated the Contact model to include error handling during frame parsing. - Refactored Channels, Contacts, Map, and Neighbours screens to utilize a new AppBarTitle widget for consistent app bar design. - Enhanced the BatteryIndicator widget to display SNR information for direct repeaters. - Introduced SNRUi class for better management of SNR icon and text representation. - Improved error handling in PathTraceMap and Neighbours screens to log errors appropriately.

…a mapping in PathTraceMapScreen

… coding based on signal strength

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ability

…peaters

…SNR indicator dialog content layout

…related screens to reflect changes Improve SNR handling by adding validation for spreading factor range in snrUiFromSNR function Update contact handling in MeshCoreConnector to fix variable naming and improve readability Stop parsing unsupported LPP types in CayenneLpp to avoid misalignment

…e for improved path management dialog

…y; update related UI components to reflect changes

…e languages - Updated localization keys from "neighbours" to "neighbors" in the following files: - app_localizations_bg.dart - app_localizations_de.dart - app_localizations_en.dart - app_localizations_es.dart - app_localizations_fr.dart - app_localizations_it.dart - app_localizations_nl.dart - app_localizations_pl.dart - app_localizations_pt.dart - app_localizations_ru.dart - app_localizations_sk.dart - app_localizations_sl.dart - app_localizations_sv.dart - app_localizations_uk.dart - app_localizations_zh.dart - Updated corresponding ARB files to reflect the changes in keys. - Renamed the NeighboursScreen to NeighborsScreen in the chat and repeater hub screens for consistency.

…NR for improved accuracy

…nt dialog

…dling in channel message screens

…or outgoing messages and channel messages

* Initial plan * Wrap title Column in Expanded to prevent horizontal overflow in AppBarTitle Co-authored-by: wel97459 <12990640+wel97459@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wel97459 <12990640+wel97459@users.noreply.github.com>

- Implemented localization for "Show All Paths" in multiple languages (DE, EN, ES, FR, IT, NL, PL, PT, RU, SK, SL, SV, UK, ZH). - Updated path management dialog to include a toggle for showing all paths. - Refactored path history display logic to conditionally show paths based on the toggle state. - Cleaned up unused print statements and improved code readability in path tracing and chat screens.

…ogs based on repeaters list

…nto dev-repeaterSignal

…at and path management dialogs

Copilot

Pull request overview

This PR adds UI support for showing signal/SNR information for the nearest (direct) repeater(s), improves app bar consistency across screens, and refines path management by sorting/filtering recent paths based on nearby repeaters.

Changes:

Add a new SNR indicator widget + dialog listing nearby repeaters, and integrate it into a shared app bar title widget.
Improve path management UI/logic to sort paths and optionally hide paths not starting via nearby repeaters.
Harden protocol/frame parsing and contact refresh behavior; add tracking for “direct repeaters” based on RX advert frames.

Reviewed changes

Copilot reviewed 48 out of 49 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pubspec.lock	Updates locked dependency versions.
lib/widgets/snr_indicator.dart	New SNR UI model + indicator widget and nearby repeater dialog.
lib/widgets/path_management_dialog.dart	Adds sorting/filtering + “Show all paths” toggle based on nearby repeaters.
lib/widgets/battery_indicator.dart	Adjusts battery indicator layout to stack icon + text.
lib/widgets/app_bar.dart	Introduces `AppBarTitle` widget consolidating title + battery + SNR indicators.
lib/screens/repeater_hub_screen.dart	Renames neighbors screen reference and updates l10n keys.
lib/screens/path_trace_map.dart	Improves trace parsing robustness; changes SNR storage to `List<double>` and updates UI rendering.
lib/screens/neighbors_screen.dart	Renames Neighbours→Neighbors and adds parsing error logging.
lib/screens/map_screen.dart	Switches to shared `AppBarTitle`; minor UI polish and makes some text selectable.
lib/screens/contacts_screen.dart	Switches to shared `AppBarTitle`; adds safer frame parsing + logging.
lib/screens/chat_screen.dart	Updates path history dialog to sort/filter paths similarly to path management dialog.
lib/screens/channels_screen.dart	Switches to shared `AppBarTitle`.
lib/screens/channel_message_path_screen.dart	Adjusts path direction handling and map opening behavior for channel vs direct messages.
lib/screens/channel_chat_screen.dart	Passes `channelMessage: true` into message path screen.
lib/models/contact.dart	Tweaks trace route byte selection and makes contact parsing more defensive.
lib/helpers/cayenne_lpp.dart	Adds error handling/logging around Cayenne LPP parsing.
lib/connector/meshcore_protocol.dart	Adds bounds checks in `BufferReader`; introduces payload type constants and a new “set other params” frame builder; renames neighbors request constant.
lib/connector/meshcore_connector.dart	Adds direct repeater tracking from RX adverts; preserves path overrides on advert refresh; handles new advert push code.
lib/l10n/app_en.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_de.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_es.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_fr.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_it.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_nl.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_pl.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_pt.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_ru.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_sk.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_sl.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_sv.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_uk.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_zh.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_bg.arb	Adds new SNR/path toggle strings and renames “neighbours” keys to “neighbors”.
lib/l10n/app_localizations.dart	Updates localization interface for renamed/added keys.
lib/l10n/app_localizations_en.dart	Regenerates English localizations for new/renamed keys.
lib/l10n/app_localizations_de.dart	Regenerates German localizations for new/renamed keys.
lib/l10n/app_localizations_es.dart	Regenerates Spanish localizations for new/renamed keys.
lib/l10n/app_localizations_fr.dart	Regenerates French localizations for new/renamed keys.
lib/l10n/app_localizations_it.dart	Regenerates Italian localizations for new/renamed keys.
lib/l10n/app_localizations_nl.dart	Regenerates Dutch localizations for new/renamed keys.
lib/l10n/app_localizations_pl.dart	Regenerates Polish localizations for new/renamed keys.
lib/l10n/app_localizations_pt.dart	Regenerates Portuguese localizations for new/renamed keys.
lib/l10n/app_localizations_ru.dart	Regenerates Russian localizations for new/renamed keys.
lib/l10n/app_localizations_sk.dart	Regenerates Slovak localizations for new/renamed keys.
lib/l10n/app_localizations_sl.dart	Regenerates Slovenian localizations for new/renamed keys.
lib/l10n/app_localizations_sv.dart	Regenerates Swedish localizations for new/renamed keys.
lib/l10n/app_localizations_uk.dart	Regenerates Ukrainian localizations for new/renamed keys.
lib/l10n/app_localizations_zh.dart	Regenerates Chinese localizations for new/renamed keys.
lib/l10n/app_localizations_bg.dart	Regenerates Bulgarian localizations for new/renamed keys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-20T03:39:26Z

lib/widgets/snr_indicator.dart

+                final name = widget.connector.contacts
+                    .where((c) => c.publicKey.first == repeater.pubkeyFirstByte)
+                    .map((c) => c.name)
+                    .firstOrNull;


firstOrNull is used on an Iterable here, but there is no import providing that extension (it’s not in Dart core). This will fail to compile unless you add the appropriate extension import (e.g. from package:collection/collection.dart) or replace it with a safe isEmpty ? null : first pattern.

Copilot · 2026-02-20T03:39:26Z

lib/widgets/path_management_dialog.dart

+        final repeatersList = List.of(connector.directRepeaters)
+          ..sort((a, b) => b.ranking.compareTo(a.ranking));
+
+        if (repeatersList.isEmpty) {
+          _showAllPaths = true;
+        }


This state is being mutated during build (_showAllPaths = true). Mutating widget state in build can lead to inconsistent UI (the toggle won’t update via setState) and makes rebuilds non-idempotent. Consider deriving the effective value locally for this build, or move the initialization into initState/didUpdateWidget and update via setState when repeaters become empty.

This also BS the state only changes before the UI is built.

Copilot · 2026-02-20T03:39:26Z

lib/connector/meshcore_connector.dart

  String? get selfName => _selfName;
  double? get selfLatitude => _selfLatitude;
  double? get selfLongitude => _selfLongitude;
+  List<DirectRepeater> get directRepeaters => _directRepeaters;


Other list getters in this class return List.unmodifiable(...), but directRepeaters exposes the mutable backing list directly. This allows external callers to modify connector state without notifications. Consider returning an unmodifiable view/copy (e.g. List.unmodifiable(_directRepeaters)) for consistency and safety.

Suggested change

List<DirectRepeater> get directRepeaters => _directRepeaters;

List<DirectRepeater> get directRepeaters => List.unmodifiable(_directRepeaters);

Copilot · 2026-02-20T03:39:27Z

lib/screens/path_trace_map.dart

 class PathTraceMapScreen extends StatefulWidget {
  final String title;
  final Uint8List path;
+  final int? repeaterId;
  final bool flipPathRound;
  final bool reversePathRound;

  const PathTraceMapScreen({
    super.key,
    required this.title,
    required this.path,
+    this.repeaterId,


repeaterId is declared but never used in this screen. If it’s not needed yet, removing it avoids analyzer warnings; if it is intended for future logic, consider wiring it into the trace/map behavior so the field is meaningful.

This will be used to include the end repeater in the path. i'll add it in the next PR.

just-stuff-tm · 2026-02-20T15:52:31Z

is my pr gonna interfere with this pr

#198
Overflow and title-fit hardening
Added reusable adaptive AppBar title widget:

lib/widgets/adaptive_app_bar_title.dart
Applied to major screens to prevent title truncation/overflow for long localized titles.

Also fixed mobile overflow issues:

Path Trace overlay action controls made responsive (wrap instead of horizontal overflow).
Contact tile text/trailing layout hardened for narrow screens and long strings:
lib/screens/contacts_screen.dart
lib/screens/map_screen.dart

wel97459 and others added 30 commits February 14, 2026 14:19

Fix trace route bytes generation logic in Contact model

63aa515

Ignore advertisements from self in MeshCoreConnector

cdda232

Refactor PathTraceData to use List<double> for snrData and adjust dat…

fa5a093

…a mapping in PathTraceMapScreen

Add SNRIndicator to AppBar and refactor BatteryIndicator layout

5751cdd

Enhance path management dialog to display direct repeaters with color…

246cf99

… coding based on signal strength

Remove unused import from SNR indicator widget

3f80ae1

Update lib/models/contact.dart

152d5f8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update lib/connector/meshcore_connector.dart

4019741

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update lib/connector/meshcore_connector.dart

04f5c44

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update lib/screens/path_trace_map.dart

608b6fb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update lib/widgets/battery_indicator.dart

03b3533

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update lib/helpers/cayenne_lpp.dart

1589883

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Refactor packet handling to skip only the RSSI byte for improved reli…

e6814b4

…ability

Add SNR indicator localization and update UI references for nearby re…

75a7f43

…peaters

Handle loading state and error parsing in PathTraceMapScreen; update …

940a1be

…SNR indicator dialog content layout

Throw an exception for unsupported LPP types in CayenneLpp class

71152bd

Sort direct repeaters by last updated time and SNR; limit to top thre…

a68e1dd

…e for improved path management dialog

Prevent notifications for chat and sensor adverts without a valid path

3640121

Implement ranking system for direct repeaters based on SNR and recenc…

42eb293

…y; update related UI components to reflect changes

Adjust ranking calculation for direct repeaters by adding offset to S…

14cec53

…NR for improved accuracy

Fix typo in variable name for second direct repeater in path manageme…

0a01ecd

…nt dialog

Refactor ranking calculation for direct repeaters and update path han…

17a9db0

…dling in channel message screens

Refactor path handling in ChannelMessagePathScreen to improve logic f…

b8acedd

…or outgoing messages and channel messages

Refactor AppBarTitle widget to simplify Text widget initialization

7575936

Merge branch 'main' into dev-repeaterSignal

ab5ccf9

wel97459 added 5 commits February 18, 2026 17:55

Refactor FeatureToggleRow visibility in chat and path management dial…

4d4d2a7

…ogs based on repeaters list

Merge branch 'dev-repeaterSignal' of github.com:zjs81/meshcore-open i…

2475db4

…nto dev-repeaterSignal

Remove unused import of 'dart:ffi' in path_trace_map.dart

9396d90

Refactor repeater management logic and update UI state handling in ch…

c8266df

…at and path management dialogs

Refactor RX data handling and improve repeater management logic in ch…

e0f7c2b

…at and path management dialogs

Copilot AI review requested due to automatic review settings February 20, 2026 03:31

Copilot started reviewing on behalf of wel97459 February 20, 2026 03:32 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Add a signal readout for the nearest repeater. With improvements to app bar and other UI polish.#200

Add a signal readout for the nearest repeater. With improvements to app bar and other UI polish.#200
wel97459 wants to merge 35 commits intomainfrom
dev-repeaterSignal

wel97459 commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

wel97459 Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

wel97459 Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

Copilot AI Feb 20, 2026

Uh oh!

wel97459 Feb 20, 2026

Uh oh!

just-stuff-tm commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	List<DirectRepeater> get directRepeaters => _directRepeaters;
	List<DirectRepeater> get directRepeaters => List.unmodifiable(_directRepeaters);

Comments

Conversation

wel97459 commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

wel97459 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

wel97459 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

wel97459 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

just-stuff-tm commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants