Skip to content

Comments

Update Polish localization strings for clarity#29

Open
thesebas wants to merge 5 commits intozjs81:mainfrom
thesebas:patch-1
Open

Update Polish localization strings for clarity#29
thesebas wants to merge 5 commits intozjs81:mainfrom
thesebas:patch-1

Conversation

@thesebas
Copy link

No description provided.

Copy link
Owner

@zjs81 zjs81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the Polish translations! The terminology fixes (especially "rozgłoszenie" instead of "reklama") are correct for mesh networking context.

Issues to fix before merging:

  1. Typo in app_localizations_pl.dart:

    // Current (wrong):
    String get repeater_cliHelpNeighbors =>
        'Wyświetla listę innych węzłów powtarzających się, które usłyszano dzięki rozgłszeniom zero-hop...';
    
    // Should be (note the missing 'o' in rozgłoszeniom):
    String get repeater_cliHelpNeighbors =>
        'Wyświetla listę innych węzłów powtarzających się, które usłyszano dzięki rozgłoszeniom zero-hop...';
  2. Missing .arb file changes:

    The source of truth for localizations is the .arb file. Please update lib/l10n/app_pl.arb with the same changes, then run:

    flutter gen-l10n

    This ensures the .arb and .dart files stay in sync and prevents your changes from being overwritten if someone regenerates the localization files.

@446564 446564 changed the title Update Polish localization strings for clarity WIP: Update Polish localization strings for clarity Feb 1, 2026
@446564 446564 marked this pull request as draft February 1, 2026 04:10
@446564
Copy link
Collaborator

446564 commented Feb 1, 2026

@thesebas once changes are addressed please mark ready for review and we can get this in 😀

@446564
Copy link
Collaborator

446564 commented Feb 15, 2026

Are you still interested in working on this @thesebas

Copilot AI review requested due to automatic review settings February 18, 2026 18:10
@thesebas
Copy link
Author

Are you still interested in working on this @thesebas

Yes, thank you for checking this PR, pushed some more updates and executed requested arb/dart generation tasks.

@thesebas thesebas marked this pull request as ready for review February 18, 2026 18:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates Polish localization strings to improve clarity and accuracy. The main focus is replacing "reklama" (commercial advertisement) with "rozgłoszenie" (broadcast/announcement) throughout the mesh networking context, along with several other translation improvements and grammatical fixes.

Changes:

  • Replaced "reklama" with "rozgłoszenie" for mesh network broadcasts/advertisements (30+ occurrences)
  • Fixed spelling and grammar errors (e.g., "widiany" → "widziany", "odkryte" → "wykryte")
  • Improved technical terminology (e.g., "Rozkład Czynnika" → "Współczynnik rozpraszania", "Paski" → "kafelki")
  • Updated flood routing terminology from "Powodzie"/"Powódź" to "Zalew" for better clarity

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/l10n/app_pl.arb Updated Polish localization strings for clarity, replacing commercial advertisement terms with broadcast terminology and fixing spelling/grammar errors
lib/l10n/app_localizations_pl.dart Auto-generated Dart localization file reflecting the .arb changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@446564 446564 changed the title WIP: Update Polish localization strings for clarity Update Polish localization strings for clarity Feb 18, 2026
@thesebas
Copy link
Author

Actually, I'm working on even more corrections; that batch was what I found in the app UI. Now I'm going label by label and trying to make it more consistent and use better wording. I'll add it to this PR if that's okay; otherwise, I'll prepare a separate one.

Copilot AI review requested due to automatic review settings February 18, 2026 18:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thesebas
Copy link
Author

I'm unsure about translating those few technical terms (flood, repeater and route) but I think in Polish they sound more natural. If other users decide that it sounds unprofessional, they can always create a PR. :)

@thesebas thesebas requested a review from zjs81 February 18, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants