Update Polish localization strings for clarity#29
Update Polish localization strings for clarity#29thesebas wants to merge 5 commits intozjs81:mainfrom
Conversation
zjs81
left a comment
There was a problem hiding this comment.
Thanks for improving the Polish translations! The terminology fixes (especially "rozgłoszenie" instead of "reklama") are correct for mesh networking context.
Issues to fix before merging:
-
Typo in
app_localizations_pl.dart:// Current (wrong): String get repeater_cliHelpNeighbors => 'Wyświetla listę innych węzłów powtarzających się, które usłyszano dzięki rozgłszeniom zero-hop...'; // Should be (note the missing 'o' in rozgłoszeniom): String get repeater_cliHelpNeighbors => 'Wyświetla listę innych węzłów powtarzających się, które usłyszano dzięki rozgłoszeniom zero-hop...';
-
Missing
.arbfile changes:The source of truth for localizations is the
.arbfile. Please updatelib/l10n/app_pl.arbwith the same changes, then run:flutter gen-l10n
This ensures the
.arband.dartfiles stay in sync and prevents your changes from being overwritten if someone regenerates the localization files.
|
@thesebas once changes are addressed please mark ready for review and we can get this in 😀 |
|
Are you still interested in working on this @thesebas |
Yes, thank you for checking this PR, pushed some more updates and executed requested arb/dart generation tasks. |
There was a problem hiding this comment.
Pull request overview
This pull request updates Polish localization strings to improve clarity and accuracy. The main focus is replacing "reklama" (commercial advertisement) with "rozgłoszenie" (broadcast/announcement) throughout the mesh networking context, along with several other translation improvements and grammatical fixes.
Changes:
- Replaced "reklama" with "rozgłoszenie" for mesh network broadcasts/advertisements (30+ occurrences)
- Fixed spelling and grammar errors (e.g., "widiany" → "widziany", "odkryte" → "wykryte")
- Improved technical terminology (e.g., "Rozkład Czynnika" → "Współczynnik rozpraszania", "Paski" → "kafelki")
- Updated flood routing terminology from "Powodzie"/"Powódź" to "Zalew" for better clarity
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/l10n/app_pl.arb | Updated Polish localization strings for clarity, replacing commercial advertisement terms with broadcast terminology and fixing spelling/grammar errors |
| lib/l10n/app_localizations_pl.dart | Auto-generated Dart localization file reflecting the .arb changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Actually, I'm working on even more corrections; that batch was what I found in the app UI. Now I'm going label by label and trying to make it more consistent and use better wording. I'll add it to this PR if that's okay; otherwise, I'll prepare a separate one. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm unsure about translating those few technical terms (flood, repeater and route) but I think in Polish they sound more natural. If other users decide that it sounds unprofessional, they can always create a PR. :) |
No description provided.