Skip to content

Conversation

@sidsbrmnn
Copy link

@sidsbrmnn sidsbrmnn commented Mar 6, 2023

This pull request is to remove a lock on Libtool used by Amanda during build process. Amanda uses GNU Autotools (Autoconf, Automake and Libtool) for portable builds. Libtool is currently locked at version 2.4.6 and is tracked by Git. It is in good practice to ignore the files generated by Autotools while checking the code into any version control system.

Changes Made

  • delete libtool-related files and ignore them on .gitignore
  • initialize libtool in configure.ac
  • trigger libtoolize during ./autogen to regenerate these files
  • remove text on updating libtool in DEVELOPING as it is now system-dependent

I also added a .gitignore file to each directory to ignore Amanda's distribution files such that the ignore file in the root of the project contains a list of files based on the Operating System, VCS, Tools and Frameworks and IDEs used. The inner directories contain an ignore file with the distribution files generated in the respective directory,.

Testing Done

I've tested the changes for build and install on CentOS 7, Rocky Linux 9 and Fedora 37.

@chandraravipati
Copy link
Collaborator

@sidsbrmnn , please add more detailed description explaining the need for these changes and explaining the changes.

@sidsbrmnn sidsbrmnn changed the title Switch to system libtool Remove libtool from source Mar 8, 2023
@sidsbrmnn sidsbrmnn changed the title Remove libtool from source Untracking libtool-related files from Git Mar 8, 2023
@sidsbrmnn
Copy link
Author

@sidsbrmnn , please add more detailed description explaining the need for these changes and explaining the changes.

I've updated the description. I also updated the title to 'Untracking libtool-related files from Git' which is more apt to the changes made.

@amandaTrusted
Copy link
Contributor

Thank you for the contribution! We will be pulling this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants