misc #16
misc #16
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements internationalization (i18n) improvements and code style standardization across the blogmarks application. The changes primarily focus on replacing hardcoded strings with translatable functions and updating JavaScript code to use consistent quote styles.
- Replaces hardcoded strings with translatable
_()function calls for better internationalization support - Standardizes JavaScript code to use single quotes consistently throughout
- Updates French translation files with new localized strings and metadata
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| replaceables/view/side_title.php | Removes HTML formatting and adds internationalization to default title |
| public/js/bm.js | Standardizes quote usage to single quotes and adds new strongH3 function |
| locale/fr_FR.utf8/LC_MESSAGES/blogmarks.po | Updates translation metadata and adds new French translations |
| config/schema.sql | Removes tentatives column from bm_screenshots table |
| application/views/marks/form-modal.view.php | Adds commented conditional logic for private tags |
| application/modules/public.module.php | Replaces hardcoded strings with translatable functions |
| application/modules/my.module.php | Replaces hardcoded strings with translatable functions |
| application/layouts/default.layout.php | Updates footer contact information |
| application/helpers/taglist.helper.php | Optimizes tag count calculation using array functions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| $container->tags( model('tags')->from_user->__use($user) ); | ||
| $container->marks( model('marks')->from_user->__use($user, $params) ); | ||
| $sidebar->register(['Tags', 'from ' . strong($user)], function() { partial('tags'); }); | ||
| $sidebar->register([('Tags from') . ' ' . strong($user)], function() { partial('tags'); }); |
There was a problem hiding this comment.
Missing underscore function call. Should be _('Tags from') instead of ('Tags from').
| $sidebar->register([('Tags from') . ' ' . strong($user)], function() { partial('tags'); }); | |
| $sidebar->register([_('Tags from') . ' ' . strong($user)], function() { partial('tags'); }); |
| elseif ($matches = url_match('/my/marks/search/*')) { | ||
| $query = set_param('query', urldecode($matches[1])); | ||
| title(_('My Marks'), 'with search ' . strong($query)); | ||
| title(_('My Marks with search'), ' ' . strong($query)); |
There was a problem hiding this comment.
The translation string includes formatting that should be separate. Should be title(_('My Marks with search') . ' ' . strong($query)); to match the pattern used elsewhere.
| title(_('My Marks with search'), ' ' . strong($query)); | |
| title(_('My Marks with search') . ' ' . strong($query)); |
No description provided.