Fix Basic01

[tgreenx]

Purpose

This PR updates Basic01 to fix a bug (regression) introduced in the latest fix release by PR #1249.

Context

Fixes #1269

Changes

• Use functions Zonemaster::Engine::DNSName::common() and Zonemaster::Engine::DNSName::is_in_bailiwick() instead of index() to make domain names comparison.

• Refactoring.

How to test this PR

Tests should pass.

Also:

$ zonemaster-cli --show-testcase --test Basic/basic01 --level INFO norid.no
Seconds Level    Testcase       Message
======= ======== ============== =======
   0.02 INFO     UNSPECIFIED    Using version v4.7.1 of the Zonemaster engine.
   9.65 INFO     BASIC01        The parent zone is "no" as returned from name servers "i.nic.no/194.146.106.6;i.nic.no/2001:67c:1010:1::53;njet.norid.no/156.154.101.12;not.norid.no/156.154.100.12;not.norid.no/2001:502:ad09::12;x.nic.no/128.39.8.40;x.nic.no/2001:700:0:412f::40;y.nic.no/193.75.4.22;y.nic.no/2001:8c0:8200:1::2;z.nic.no/158.38.8.133;z.nic.no/2001:700:0:52d:158:38:8:133".
   9.65 INFO     BASIC01        The zone "norid.no" is found.

[tgreenx]

@matsduf I can see that branch releases/v2023.1.3 is based on top of master and not develop, is that intentional? (just making sure)

[matsduf]

@matsduf I can see that branch releases/v2023.1.3 is based on top of master and not develop, is that intentional? (just making sure)

Yes, that is intentional. v2023.1.3 should not include other things that have been merged to develop branch after the latest release, only the fixes for that fix release.

[tgreenx]

Unit tests are failing (on Ubuntu), while it works fine on my computer (Debian). I can see where the error is supposed to be from the logs but unsure as to why it happens yet.

[tgreenx]

Unit tests are failing (on Ubuntu), while it works fine on my computer (Debian). I can see where the error is supposed to be from the logs but unsure as to why it happens yet.

So the error was due to the fact that chained comparisons support was only added in Perl v5.32 (see https://metacpan.org/release/XSAWYERX/perl-5.32.0/view/pod/perldelta.pod#Chained-comparisons-capability). I have provided an update to the code in that regard.

[matsduf]

I have installed and tested the new code and it seems to behave correctly. The code of method basic01() is quite hard to follow. Could it be give some more documentation to make it easier to follow it?

[tgreenx]

I have installed and tested the new code and it seems to behave correctly. The code of method basic01() is quite hard to follow. Could it be give some more documentation to make it easier to follow it?

I think we can proceed as is. The code is following the specification to the letter, so I don't know what more I can add in that regard.