Skip to content

Fix missing value in Zone11 message tag#1491

Merged
tgreenx merged 2 commits intozonemaster:release/v2025.2.1from
tgreenx:fix-zone11
Feb 9, 2026
Merged

Fix missing value in Zone11 message tag#1491
tgreenx merged 2 commits intozonemaster:release/v2025.2.1from
tgreenx:fix-zone11

Conversation

@tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Jan 21, 2026

Purpose

This PR fixes a missing value for message tag Z11_NO_SPF_NON_MAIL_DOMAIN in Zone11 test case.

How to test this PR

Tests should still pass.

Manual testing:

  • Before this PR:
$ zonemaster-cli --show-testcase --level INFO --test zone11 --no-ipv6 fr

Seconds Level    Testcase       Message
======= ======== ============== =======
   0.00 INFO     Unspecified    Using version v8.1.0 of the Zonemaster engine.
   9.72 INFO     Zone11         No SPF policy was found for {domain}, which is a type of domain (root, TLD or under .ARPA) not expected to be used for email.
  • After:
$ zonemaster-cli --show-testcase --level INFO --test zone11 --no-ipv6 fr

Seconds Level    Testcase       Message
======= ======== ============== =======
   0.00 INFO     Unspecified    Using version v8.1.0 of the Zonemaster engine.
   9.70 INFO     Zone11         No SPF policy was found for fr, which is a type of domain (root, TLD or under .ARPA) not expected to be used for email.

@tgreenx tgreenx added this to the v2026.1 milestone Jan 21, 2026
@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case V-Patch Versioning: The change gives an update of patch in version. RC-Fixes Release category: Fixes. labels Jan 21, 2026
@tgreenx
Copy link
Contributor Author

tgreenx commented Jan 21, 2026

(Candidate for v2025.2.1)

marc-vanderwal
marc-vanderwal previously approved these changes Jan 21, 2026
@tgreenx tgreenx modified the milestones: v2026.1, v2025.2.1 Jan 27, 2026
matsduf
matsduf previously approved these changes Jan 28, 2026
@matsduf
Copy link
Contributor

matsduf commented Jan 28, 2026

Do we really have to say what domain it is when it is the tested domain?

@marc-vanderwal
Copy link
Contributor

Maybe not, but I don’t see how to word the message differently.

@matsduf
Copy link
Contributor

matsduf commented Jan 28, 2026

Maybe not, but I don’t see how to word the message differently.

I do not suggest any change now, but e.g.

No SPF policy was found for the tested domain, which is a type of domain (...)

@matsduf matsduf changed the base branch from develop to release/v2025.2.1 January 28, 2026 14:08
@matsduf matsduf dismissed stale reviews from marc-vanderwal and themself January 28, 2026 14:08

The base branch was changed.

@tgreenx tgreenx merged commit 3a14c73 into zonemaster:release/v2025.2.1 Feb 9, 2026
3 checks passed
@tgreenx tgreenx deleted the fix-zone11 branch February 9, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-TestCase Area: Test case specification or implementation of test case RC-Fixes Release category: Fixes. V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments