Conversation
… slash to result and history URLs.
matsduf
requested review from
MichaelTimbert,
marc-vanderwal,
mattias-p,
tgreenx and
tolvmannen
matsduf
approved these changes
Dec 18, 2025
Contributor
matsduf
left a comment
matsduf
left a comment
There was a problem hiding this comment.
As far as I can see filtering works.
tgreenx
approved these changes
Dec 18, 2025
Contributor
tgreenx
left a comment
tgreenx
left a comment
There was a problem hiding this comment.
Release tested on Debian 13 and works as advertised. Thanks for the fix!
| if (currentState === 'complete' && previousState === 'testing') { | ||
| const base = import.meta.env.BASE_URL; | ||
| document.location.href = `${base}${getLocale()}/result/${currentContext.testId}`; | ||
| document.location.href = `${base}${getLocale()}/result/${currentContext.testId}/`; |
Contributor
There was a problem hiding this comment.
(Out of curiosity, any particular reason for this change?) Nvm, commit 692f1dc message description explains it :)
tgreenx
added
the
V-Patch
MichaelTimbert
approved these changes
Dec 18, 2025
MichaelTimbert
left a comment
MichaelTimbert
left a comment
There was a problem hiding this comment.
Release tested on Rocky 8. Everything good.
marc-vanderwal
approved these changes
Dec 18, 2025
Contributor
marc-vanderwal
left a comment
marc-vanderwal
left a comment
There was a problem hiding this comment.
Tested it on my end and I see no problems either. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #525
Context
resultcould no longer be updated after it was converted to a derived rune, since derived state is immutable. This change moves the filtering logic into the derived computation somodulesandmodulesMapupdate reactively.Changes
resultfiltering into the derived computationmodulesandmodulesMapupdate when filters changeHow to test this PR
Run a test and apply filters to the result. Verify that the displayed modules update correctly.