Code updates #8
Open
Code updates #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unsigned casts explicitly stated, fixed initial position of preferences XIB
Owner
|
Thanks for the PR! I'd be happy to merge it in, but there is one small thing: the project unfortunately must remain GC-enabled in the repository. That's because Lion is supported, and Lion's System Preferences does not work non-GC prefpanes (as explained in the readme). Code is written in such fashion that it should behave correctly when compiled with either GC or ARC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed universal developer ID, GC converted to ARC, unchecked signed-unsigned casts explicitly stated, fixed initial position of preferences XIB
Overall just some small changes and warnings fixed, when opening project in XCode (my env XCode 6.3.2, Yosemite 10.10.3)
Summary