Add intro modals for Inbox and Combined Feed #2045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
See the project's README: Before we can review this PR, it will need tests. |
khanak0509
force-pushed
the
intro-modals-1856
branch
from
515d93e to
14cb420
Compare
Contributor
Author
|
now I have added test and also added test detection code in dialog.dart but when I added test detection it solved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1856
Adds one-time intro modals for inbox and combined feed screens to help new users understand what each view shows.
screenshots -
as mentioned in issue description and CZO discussion: #mobile > Intro video? intro is showing once per install of the app even if they login again . and if they reinstall the add it will visible again .
Tested on iOS emulator:
(1) Fresh install shows both modals on first visit
(2)Modals don't reappear after tapping "Got it"
(3) Modals stay dismissed across app restarts
(4) Reinstalling app shows modals again
video of testing
https://drive.google.com/file/d/1vg3yrCxwh44TSUv6730K7Lr-CPrxI1cm/view?usp=sharing
all tests passed
