Skip to content

Conversation

@Aeotec-ccheng
Copy link
Contributor

Adds latest firmware update for new Z-Stick 10 Pro not yet updated to 7.23.2

@Aeotec-ccheng
Copy link
Contributor Author

@AlCalzone not sure if this is correct, but followed the flow of other Z-Wave update files i've done but for the controller instead. Let me know if there are any changes that are needed.

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay in general but I'm not sure about those version numbers. Are they correct?

- Fix Version Number from 2.z.y to 7.z.y
@Aeotec-ccheng
Copy link
Contributor Author

@AlCalzone just for future formatting should firmware versions be listed as x.y.z or x.y (i remembered z digit didn't matter in the past, wondering if this changed).

@AlCalzone
Copy link
Member

.z can normally be left out if it is zero, and will be assumed to be zero.
If you use the .z portion in your firmware versions, you should also include it here.

The problem with controller firmwares though is that there is no way to retrieve that portion of the firmware version. So if the firmware has version 7.23.2, Z-Wave JS only sees 7.23 and assumes it to be 7.23.0.

@Aeotec-ccheng
Copy link
Contributor Author

@AlCalzone I've removed the .0 for the .z decimal point everything that is above 0 has been included. Let me know if there are anymore changes that are needed.

Updated firmwareVersion from x.y.z decimal to x.y as well was upgrade version.
reverting change on line 11, as i was only requested to change on line 17.
@Aeotec-ccheng
Copy link
Contributor Author

@AlCalzone hopefully this one is the final check to push this one through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants