-
-
Notifications
You must be signed in to change notification settings - Fork 51
Add Heatit Z-TRM6 v1.0.11 and Z-Temp3 v1.0.6 #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AlCalzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeatitControls this looks good. Just one suggestion and a question. Let me know how you want to proceed.
| ], | ||
| "upgrades": [ | ||
| { | ||
| "version": "1.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any limitation on upgrade paths? Are there versions that may not be updated or downgraded to this version?
If not, this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No limitations apart from that you can only upgrade to newer versions. Downgrades are not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then we need to keep that in mind when there is a future update. The applicable updates can be limited like this
"$if": "firmwareVersion < 1.0.11",
for example.
|
@HeatitControls you also added the Z-Temp3 to the same branch now. In general that's okay, but for the future I recommend a slightly different workflow:
We use squash-merging, which causes your main branch to diverge and require merge commits every time to get back in sync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One slight issue:
changed sha to lowercase for temp3 Co-authored-by: AlCalzone <d.griesel@gmx.net>
AlCalzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is the first time we publish an OTA here, please let me know if there is anything wrong with the .json