Fixed compilation for Windows #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I watched your talk about VTG and I want to use it for a project, but I realized that it has some problems when compiling in Windows, mainly because SAV1 uses the function
clock_gettime, which is POSIX-only, and because the meson file didn't use the correct paths to look for dependencies.I understand that you are working on mac and therefore you're probably not focusing on windows-specific problems yet so I made the necessary changes to get SAV1 to compile on windows without changing the current behavior for linux and mac.
The compilation still wasn't as straightforward as it is on linux and mac for me but mostly because meson and scons were defaulting to x86 for some reason, but once I managed to make them point to the correct paths SAV1 compiled correctly and I could build VTG for Windows.
I hope you're OK with this changes and if you accept my PR I'd be glad to contribute to the VTG repo with the other changes needed for building on WIndows.