Add missing Compatibility Library handling for VecDocumentVersion#getSpecificationWithType#443
Open
DManstrator wants to merge 4 commits intodevelopfrom
Open
Conversation
DManstrator
added
Compatibility
DManstrator
force-pushed
the
bugfix/compatibility-wrapping-of-get-specification-with-type
branch
2 times, most recently
from
f9d4dae to
5ac19ce
Compare
Collaborator
Author
|
@beckerjohannes: I didn't create the |
5 tasks
beckerjohannes
requested changes
Feb 10, 2026
Contributor
beckerjohannes
left a comment
beckerjohannes
left a comment
There was a problem hiding this comment.
The rest looks fine, However, it is not mergeable because of conflict.
Comment on lines
+106
to
+107
| .filter(Optional::isPresent) | ||
| .map(Optional::get) |
Contributor
There was a problem hiding this comment.
For that, the Optional has a flatMap function. .flatMap(v -> v) would have the same result and is more readable
Collaborator
Author
There was a problem hiding this comment.
This seems to cause type erasure of the generic here so I would keep it like it's currently is.
Is that okay for you?
…t Optionals properly
# Conflicts: # compatibility/compatibility-vec12to20/src/test/java/com/foursoft/harness/compatibility/vec12to20/wrapper/vec12to20/Vec12To20DocumentVersionWrapperTest.java
… VEC 1.2 conversion
DManstrator
force-pushed
the
bugfix/compatibility-wrapping-of-get-specification-with-type
branch
from
ef9c03f to
c6eb90e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Changes
Description
The
VecDocumentVersionclasses implementHasSpecificationswhich definegetSpecificationsWithTypeandgetSpecificationWithType. Due to that, the Compability Library needs to define special handling for those methods. ThegetSpecificationsWithTypemethod was already covered butgetSpecificationWithTypewas still missing.This PR adds the missing handling for
getSpecificationWithType.