Two fixes for reading CNH Pro1200 Harvest data #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stop forcing CategoryEnum.Variety to OperationTypeEnum.SowingAndPlanting (could be Harvesting) - In GetOperationTypeFromLoggingDevices, prefer a non-Unknown operation type
Contributor
|
Looks good to me. @strhea can you also review/merge? |
Contributor
|
Done
From: Kelly Nelson ***@***.***>
Date: Thursday, August 7, 2025 at 15:18
To: ADAPT/ISOv4Plugin ***@***.***>
Cc: Stuart Rhea ***@***.***>, Mention ***@***.***>
Subject: Re: [ADAPT/ISOv4Plugin] Two fixes for reading CNH Pro1200 Harvest data (PR #256)
[Image removed by sender.]knelson-farmbeltnorth left a comment (ADAPT/ISOv4Plugin#256)<#256 (comment)>
Looks good to me. @strhea<https://github.com/strhea> can you also review/merge?
—
Reply to this email directly, view it on GitHub<#256 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABLZQXQ7SOOQKHXNRKNUZHL3MOYAPAVCNFSM6AAAAACDL5MBN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRVGU4DMMZUGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
|
@adv12 Do you have any additional changes pending, or can I proceed to release these changes? |
Contributor
Author
|
@knelson-farmbeltnorth This is all I know of at the present. Thanks for the fast turnaround! |
Contributor
|
@adv12 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have harvest data from a CNH Pro1200 display that is coming in as SowingAndPlanting with 5.6.2. Additionally, we observed that sometimes Unknown is being returned from TimeLogMapper.GetOperationTypeFromLoggingDevices when there was a more meaningful operation available in the list. This PR addresses those two issues with the following changes: