Skip to content

Conversation

@hsuan-lun-chiang
Copy link
Collaborator

@hsuan-lun-chiang hsuan-lun-chiang commented Dec 29, 2025

Description

When running MaxText benchmarks, use_vertex_tensorboard and vertex_tensorboard_project may be converted to None. The MaxTextConfig Pydantic model currently enforces strict string types, causing a ValidationError (Input should be a valid string).

This change updates the config definition to Optional[str]. This allows the fields to accept None during validation.

Error Log

Tests

python3 -m benchmarks.benchmark_runner on-device --base_output_directory gs://maxtext-test/ --run_name="test-run" --num_steps=5

Logs

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hsuan-lun-chiang hsuan-lun-chiang force-pushed the fix/vertex-tensorboard-pydantic branch from 527c0b4 to 065fa1a Compare December 29, 2025 10:38
Copy link
Collaborator

@NicoGrande NicoGrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants