Skip to content

Fix Pydantic validation error for Vertex Tensorboard args #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsuan-lun-chiang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Pydantic validation error for Vertex Tensorboard args #2893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/MaxText/configs/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Copyright 2023–2025 Google LLC
#

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Expand Down Expand Up @@ -1302,8 +1302,8 @@ class Tensorboard(BaseModel):

enable_tensorboard: bool = Field(True, description="Enable Tensorboard logging.")
use_vertex_tensorboard: bool = Field(False, description="Set to True for GCE, False if running via XPK.")
vertex_tensorboard_project: str = Field("", description="GCP project for Vertex AI Tensorboard.")
vertex_tensorboard_region: str = Field("", description="Region for Vertex AI Tensorboard.")
vertex_tensorboard_project: Optional[str] = Field("", description="GCP project for Vertex AI Tensorboard.")
vertex_tensorboard_region: Optional[str] = Field("", description="Region for Vertex AI Tensorboard.")


class MultimodalGeneral(BaseModel):
Expand Down
Loading