Open
Conversation
Contributor
|
I forgot, but apparently to install irdb dependencies like |
Contributor
Author
|
Yeah, I updated the description after I found out. Seems to work now: https://github.com/AstarVienna/ScopeSim_Data/actions/runs/21747930854 |
teutoburg
changed the title
Contributor
Author
|
In an ideal world, I would have done #31 before this... Although we could still merge that one first and then rebase this (and wait for another 2 h for the workflow to run...). |
teutoburg
force-pushed
the
teutoburg-patch-1
branch
from
ef24556 to
7ff25e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IRDB doesn't use poetry (yet), but rather a setup.py file. I recently removed the version.py file there, causing the installation to fail. The obvious solution would be to fix this in the IRDB, and I will do that. But than it occurred to me, why do we even need to install the IRDB here? What does it even mean to "install the IRDB"?? Well, I'm assuming this is to make sure all the test dependencies are here to run the tests. But all of those are already installed anyway from all the other packages.
Well, that didn't work, because the "internal" IRDB tests have at least one unique dependency. However, installing from
requirements.github_actions.txtfor the case of the IRDB seems to work, which is how the tests are run in the CI over there anyway...