Skip to content

Run main script also on PR#31

Merged
teutoburg merged 5 commits intomainfrom
teutoburg-patch-2
Feb 6, 2026
Merged

Run main script also on PR#31
teutoburg merged 5 commits intomainfrom
teutoburg-patch-2

Conversation

@teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Feb 6, 2026

  • Only run on non-draft PRs
  • Don't run Slack bot notification for PRs

@teutoburg teutoburg self-assigned this Feb 6, 2026
@teutoburg teutoburg marked this pull request as ready for review February 6, 2026 12:50
@teutoburg teutoburg marked this pull request as draft February 6, 2026 12:51
Blindly copy-pasted from IRDB.....
@teutoburg teutoburg marked this pull request as ready for review February 6, 2026 12:53
@teutoburg
Copy link
Contributor Author

Fails because #30 isn't in yet. Although I'd prefer merging this first, to get a nice green check on the other one. But either way will be fine...

@teutoburg teutoburg requested a review from hugobuddel February 6, 2026 13:04
Copy link
Contributor

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requiring a user to manually start the job was deliberate, because it takes two hours.

But perhaps having the job not run for draft PRs is good enough. It is nice to get a checkmark yes.

We can always change it back.

@teutoburg
Copy link
Contributor Author

It just occurred to me that the main workflow can create a PR if there's newly downloaded data (indeed the original purpose of this!), could this mean we might end up in a recursion here? Maybe only trigger this with a specific label or give the auto PR a label and don't fire when that's there...

The automated PR already has a unique label, so can just use that to avoid the risk of eternal loops...
@hugobuddel
Copy link
Contributor

could this mean we might end up in a recursion here?

Oops; thanks.

@teutoburg teutoburg merged commit 8086fa3 into main Feb 6, 2026
2 of 3 checks passed
@teutoburg teutoburg deleted the teutoburg-patch-2 branch February 6, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants