Skip to content

Remove Arcane Power talent from spell damage calculation #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alessandro-Barbieri wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove Arcane Power talent from spell damage calculation #385

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0e29fa
Remove Arcane Power talent from spell damage calculation
Alessandro-Barbieri Dec 14, 2025
9fca92b
more changes
Alessandro-Barbieri Dec 22, 2025
e617529
revert
Alessandro-Barbieri Dec 23, 2025
6266dd9
revert
Alessandro-Barbieri Dec 23, 2025
242edf6
revert
Alessandro-Barbieri Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions Modules/Data/SpellDamage.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,13 @@ local Data = ECSLoader:ImportModule("Data")
---@type DataUtils
local DataUtils = ECSLoader:ImportModule("DataUtils")

local _SpellDamage = {}

local _, _, classId = UnitClass("player")

---@param school number
---@return number
function Data:GetSpellDamage(school)
local spellDmg = GetSpellBonusDamage(school)
local modifier = _SpellDamage:GetGeneralTalentModifier()
spellDmg = spellDmg * (1 + (modifier / 100))
return DataUtils:Round(spellDmg, 0)
end

---@return number
function _SpellDamage:GetGeneralTalentModifier()
local mod = 0

if classId == Data.MAGE then
local talentSlot = ECS.IsWotlk and 17 or 14
local _, _, _, _, points, _, _, _ = GetTalentInfo(1, talentSlot)
mod = points * 1 -- 0-3% Arcane Instability
end

return mod
end

---@return number
function Data:SpellPenetration()
return DataUtils:Round(GetSpellPenetration(), 2) .. "%"
Expand All @@ -49,4 +30,4 @@ end
function Data:GetSpellHasteBonus()
local hasteBonus = GetCombatRatingBonus(CR_HASTE_SPELL)
return DataUtils:Round(hasteBonus, 2) .. "%"
end
end
Loading