-
Notifications
You must be signed in to change notification settings - Fork 20
Remove Arcane Power talent from spell damage calculation #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove Arcane Power talent from spell damage calculation #385
Conversation
|
I don't think it is correct to rename "Spell Damage" to "Spell Power". Spell Power was introduced in WotLK to combine Spell Damage and Healing Power. While it would be correct for WotLK I don't think it is worth curating multiple translations for this difference. That being that, I'd be happy to see #375 fixed if it is indeed incorrect to add that 1% to the spell damage value. |
|
What's the best wording that doesn't confuse the user? Something that doesn't sound that the value shown is the final damage (comprehensive of bonuses) but only the "power". |
1bb395a to
e0e29fa
Compare
I have no clue tbh. I do get your point though, that it might not be clear that the value shown is not the actual spell damage, but only a part of the damage bonus 🤔 Could a "bonus" help here? |
Modules/i18n/translations/ConfigTranslations/SpellConfigTranslations.lua
Outdated
Show resolved
Hide resolved
|
I am honestly not sure how to proceed with this PR. Changing the wording from "nature damage" to "nature spell damage" (and so on) means, that all the translations for this also become invalid. And I am not sure if anything becomes more clear when adding "spell". What would it be confused with in the first place? |
#375