fix(security): remediate SonarQube vulnerabilities#82
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
fix(security): remediate SonarQube vulnerabilities#82devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
- Define constants for duplicated string literals: - errFailedToGetPullRequest - errFailedToGetCurrentUser - errFailedToGetLatestReviewForCurrUser - Refactor GetPullRequestFiles to reduce cognitive complexity: - Extract parameter extraction into extractPullRequestFilesParams - Extract API call into fetchPullRequestFiles helper - Use MarshalledTextResult for response marshaling Addresses SonarQube issues: - S1192: Duplicated string literals (3 issues) - S3776: Cognitive complexity too high (1 issue) Co-Authored-By: parker.duff@codeium.com <pwjduff@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Reverted GetPullRequestFiles to inline parameter extraction - Kept constants for S1192 fix (duplicated string literals) - Kept MarshalledTextResult usage for cleaner marshaling - Removed pullRequestFilesParams struct and helper functions Co-Authored-By: parker.duff@codeium.com <pwjduff@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: N/A (SonarQube remediation)
Summary
This PR addresses SonarQube issues in
pkg/github/pullrequests.go:S1192 - Duplicated String Literals (3 issues)
errFailedToGetPullRequest(was duplicated 4 times)errFailedToGetCurrentUser(was duplicated 3 times)errFailedToGetLatestReviewForCurrUser(was duplicated 3 times)S3776 - Cognitive Complexity (1 issue)
GetPullRequestFilesby using existingMarshalledTextResultutility instead of manual JSON marshalingReview Checklist
"failed to get pull request: %s"to"%s: %s", errFailedToGetPullRequestproduce identical outputMarshalledTextResulthandles marshaling errors appropriately (it returns an error result on failure)Alternatives Considered
Initially extracted helper functions (
extractPullRequestFilesParams,fetchPullRequestFiles) to reduce cognitive complexity, but this triggered SonarCloud duplication warnings (17.4% duplication on new code). Reverted to inline parameter extraction while keeping theMarshalledTextResultsimplification.Link to Devin run: https://app.devin.ai/sessions/5e198d746b8c41219984d3af0e6df8d2
Requested by: @parkerduff