Skip to content

fix(security): remediate SonarQube vulnerabilities #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(security): remediate SonarQube vulnerabilities #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2c6fe6
fix(security): remediate SonarQube vulnerabilities (S1192, S3776)
devin-ai-integration[bot] Feb 4, 2026
19d8d86
fix: remove helper functions to address SonarCloud duplication warning
devin-ai-integration[bot] Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions pkg/github/pullrequests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ import (
"github.com/github/github-mcp-server/pkg/translations"
)

const (
errFailedToGetPullRequest = "failed to get pull request"
errFailedToGetCurrentUser = "failed to get current user"
errFailedToGetLatestReviewForCurrUser = "failed to get latest review for current user"
)

// GetPullRequest creates a tool to get details of a specific pull request.
func GetPullRequest(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Tool, server.ToolHandlerFunc) {
return mcp.NewTool("get_pull_request",
Expand Down Expand Up @@ -59,7 +65,7 @@ func GetPullRequest(getClient GetClientFn, t translations.TranslationHelperFunc)
pr, resp, err := client.PullRequests.Get(ctx, owner, repo, pullNumber)
if err != nil {
return ghErrors.NewGitHubAPIErrorResponse(ctx,
"failed to get pull request",
errFailedToGetPullRequest,
resp,
err,
), nil
Expand All @@ -71,7 +77,7 @@ func GetPullRequest(getClient GetClientFn, t translations.TranslationHelperFunc)
if err != nil {
return nil, fmt.Errorf("failed to read response body: %w", err)
}
return mcp.NewToolResultError(fmt.Sprintf("failed to get pull request: %s", string(body))), nil
return mcp.NewToolResultError(fmt.Sprintf("%s: %s", errFailedToGetPullRequest, string(body))), nil
}

r, err := json.Marshal(pr)
Expand Down Expand Up @@ -644,12 +650,7 @@ func GetPullRequestFiles(getClient GetClientFn, t translations.TranslationHelper
return mcp.NewToolResultError(fmt.Sprintf("failed to get pull request files: %s", string(body))), nil
}

r, err := json.Marshal(files)
if err != nil {
return nil, fmt.Errorf("failed to marshal response: %w", err)
}

return mcp.NewToolResultText(string(r)), nil
return MarshalledTextResult(files), nil
}
}

Expand Down Expand Up @@ -695,7 +696,7 @@ func GetPullRequestStatus(getClient GetClientFn, t translations.TranslationHelpe
pr, resp, err := client.PullRequests.Get(ctx, owner, repo, pullNumber)
if err != nil {
return ghErrors.NewGitHubAPIErrorResponse(ctx,
"failed to get pull request",
errFailedToGetPullRequest,
resp,
err,
), nil
Expand All @@ -707,7 +708,7 @@ func GetPullRequestStatus(getClient GetClientFn, t translations.TranslationHelpe
if err != nil {
return nil, fmt.Errorf("failed to read response body: %w", err)
}
return mcp.NewToolResultError(fmt.Sprintf("failed to get pull request: %s", string(body))), nil
return mcp.NewToolResultError(fmt.Sprintf("%s: %s", errFailedToGetPullRequest, string(body))), nil
}

// Get combined status for the head SHA
Expand Down Expand Up @@ -1025,7 +1026,7 @@ func CreateAndSubmitPullRequestReview(getGQLClient GetGQLClientFn, t translation
"prNum": githubv4.Int(params.PullNumber),
}); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get pull request",
errFailedToGetPullRequest,
err,
), nil
}
Expand Down Expand Up @@ -1119,7 +1120,7 @@ func CreatePendingPullRequestReview(getGQLClient GetGQLClientFn, t translations.
"prNum": githubv4.Int(params.PullNumber),
}); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get pull request",
errFailedToGetPullRequest,
err,
), nil
}
Expand Down Expand Up @@ -1240,7 +1241,7 @@ func AddPullRequestReviewCommentToPendingReview(getGQLClient GetGQLClientFn, t t

if err := client.Query(ctx, &getViewerQuery, nil); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get current user",
errFailedToGetCurrentUser,
err,
), nil
}
Expand Down Expand Up @@ -1268,7 +1269,7 @@ func AddPullRequestReviewCommentToPendingReview(getGQLClient GetGQLClientFn, t t

if err := client.Query(context.Background(), &getLatestReviewForViewerQuery, vars); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get latest review for current user",
errFailedToGetLatestReviewForCurrUser,
err,
), nil
}
Expand Down Expand Up @@ -1377,7 +1378,7 @@ func SubmitPendingPullRequestReview(getGQLClient GetGQLClientFn, t translations.

if err := client.Query(ctx, &getViewerQuery, nil); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get current user",
errFailedToGetCurrentUser,
err,
), nil
}
Expand Down Expand Up @@ -1405,7 +1406,7 @@ func SubmitPendingPullRequestReview(getGQLClient GetGQLClientFn, t translations.

if err := client.Query(context.Background(), &getLatestReviewForViewerQuery, vars); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get latest review for current user",
errFailedToGetLatestReviewForCurrUser,
err,
), nil
}
Expand Down Expand Up @@ -1501,7 +1502,7 @@ func DeletePendingPullRequestReview(getGQLClient GetGQLClientFn, t translations.

if err := client.Query(ctx, &getViewerQuery, nil); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get current user",
errFailedToGetCurrentUser,
err,
), nil
}
Expand Down Expand Up @@ -1529,7 +1530,7 @@ func DeletePendingPullRequestReview(getGQLClient GetGQLClientFn, t translations.

if err := client.Query(context.Background(), &getLatestReviewForViewerQuery, vars); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get latest review for current user",
errFailedToGetLatestReviewForCurrUser,
err,
), nil
}
Expand Down