Skip to content

NPE Bugfix #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KaiKikuchi wants to merge 1 commit into
base: 1.7
Choose a base branch
from
Open

NPE Bugfix #54

KaiKikuchi wants to merge 1 commit into from

Conversation

@KaiKikuchi
Copy link

@KaiKikuchi KaiKikuchi commented Dec 9, 2015

@KaiKikuchi KaiKikuchi changed the title NPE Bugfix #65 NPE Bugfix https://github.com/Chicken-Bones/EnderStorage/issues/65 Dec 9, 2015
@KaiKikuchi KaiKikuchi changed the title NPE Bugfix https://github.com/Chicken-Bones/EnderStorage/issues/65 NPE Bugfix Dec 9, 2015
@Chicken-Bones
Copy link
Owner

Chicken-Bones commented Dec 12, 2015

I'm always wary of fixes like this, because they break other guarantees. When the server calls sendToPlayer there's a guarantee that the client will either receive the packet, or disconnect.

Could you provide any info around the circumstances for a Player's playerNetServerHandler being null?

@Time6628 Time6628 mentioned this pull request Jan 8, 2017
Closed
@covers1624 covers1624 mentioned this pull request Apr 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KaiKikuchi @Chicken-Bones