generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 161
West Midlands | ITP-Sept-25 | Mustaf Asani | Sprint 2 | Book Library #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5e4bb13
fixed delete button element to be at the end of each row.
asaniDev 66ca3f4
fixed function to add a new book to the library
asaniDev a0ca64d
fixed delete button so a row is deleted when button clicked
asaniDev 20dbaef
removed the render function from load event since its called in popul…
asaniDev d9e3fa5
changed input type for title and author to text
asaniDev a53ccc1
added checks for author field and negative values for page number
asaniDev 9fcdbe7
used the feedback improvement guide to check other errors i might hav…
asaniDev 1b6e510
used variables to store sanitised input values, added a ternary opera…
asaniDev 5f99008
fixed bookPages variable to use for sanitising input, removed bookpag…
asaniDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,6 @@ let myLibrary = []; | |
|
|
||
| window.addEventListener("load", function (e) { | ||
| populateStorage(); | ||
| render(); | ||
| }); | ||
|
|
||
| function populateStorage() { | ||
|
|
@@ -20,29 +19,42 @@ function populateStorage() { | |
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
| const titleElem = document.getElementById("title"); | ||
| const authorElem = document.getElementById("author"); | ||
| const pagesElem = document.getElementById("pages"); | ||
| const checkBox = document.getElementById("check"); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| export function submit() { | ||
|
|
||
| if (!Number.isInteger(Number(pagesElem.value))){ | ||
| alert("Pages must be an integer !"); | ||
| return false; | ||
| } | ||
| else if ( | ||
| titleElem.value.trim() == "" || | ||
| authorElem.value.trim() == "" || | ||
| pagesElem.value == ""|| | ||
| pagesElem.value <= 0 | ||
| ) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| let book = new Book(titleElem.value.toString().trim(), authorElem.value.trim(), Number(pagesElem.value), checkBox.checked); | ||
cjyuan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| myLibrary.push(book); | ||
| render(); | ||
| titleElem.value = ""; | ||
| authorElem.value = ""; | ||
| pagesElem.value = ""; | ||
| checkBox.checked = false; | ||
| } | ||
| } | ||
|
|
||
| document.querySelector('#submitButton').addEventListener('click', () => { | ||
| submit(); | ||
| }) | ||
|
|
||
| function Book(title, author, pages, check) { | ||
| this.title = title; | ||
| this.author = author; | ||
|
|
@@ -52,52 +64,54 @@ function Book(title, author, pages, check) { | |
|
|
||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| let tableBody = document.querySelector('tbody'); | ||
|
|
||
| tableBody.innerHTML = ""; | ||
|
|
||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let row = tableBody.insertRow(0); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
| titleCell.innerText = myLibrary[i].title; | ||
| authorCell.innerText = myLibrary[i].author; | ||
| pagesCell.innerText = myLibrary[i].pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let changeButton = document.createElement("button"); | ||
| changeButton.id = i; | ||
| changeButton.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeButton); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| if (myLibrary[i].check === false) { | ||
| readStatus = "No"; | ||
| } else { | ||
| readStatus = "Yes"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| changeButton.innerText = readStatus; | ||
cjyuan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| changeButton.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| render(); | ||
| }); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| delButton.id = i + 5; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does your emoji mean? |
||
| deleteCell.appendChild(delButton); | ||
| delButton.className = "btn btn-warning"; | ||
| delButton.innerText = "Delete"; | ||
| delButton.addEventListener("click", function () { | ||
| const deletedTitle = myLibrary[i].title; | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| setTimeout(() => { | ||
| alert(`You've deleted title: ${deletedTitle}`); | ||
| }, 0) | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| .form-group { | ||
| width: 400px; | ||
| height: 300px; | ||
| align-self: left; | ||
| align-self: start; | ||
| padding-left: 20px; | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.