Skip to content

London | 25-ITP-September | Maher Abou Albourgol | Sprint 2 | Form Controls #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Maher-A-B wants to merge 11 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-September | Maher Abou Albourgol | Sprint 2 | Form Controls #880

Maher-A-B wants to merge 11 commits into from

Conversation

@Maher-A-B
Copy link

@Maher-A-B Maher-A-B commented Oct 1, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added a semantic HTML form for the T-shirt order page.
  • Collected customer name (validated for at least 2 characters), email (validated), T-shirt colour (3 radio options), and T-shirt size (6 options).
  • All fields are required.
  • Added submit button.

@netlify
Copy link

netlify bot commented Oct 1, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 9d45d3d
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68eaea9257820c0008dfe813
😎 Deploy Preview https://deploy-preview-880--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Maher-A-B Maher-A-B added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 1, 2025
@tenzyns tenzyns added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 5, 2025
tenzyns
tenzyns reviewed Oct 6, 2025
View reviewed changes
Form-Controls/index.html
<label for="email">Email:</label>
<input type="email" id="email" name="email" required />
<br /><br />
<label>T-Shirt Colour: </label>
Copy link

@tenzyns tenzyns Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the radio buttons could have their own fieldset or a div for accessibility and screen reader support?

@tenzyns tenzyns added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 6, 2025
@Maher-A-B Maher-A-B added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 13, 2025
@tenzyns
Copy link

tenzyns commented Oct 13, 2025

Good work.

@tenzyns tenzyns added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tenzyns tenzyns tenzyns left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Maher-A-B @tenzyns