Skip to content

London | 25-ITP-September | Maher Abou Albourgol | Sprint 2 | Form Controls #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maher-A-B wants to merge 11 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-September | Maher Abou Albourgol | Sprint 2 | Form Controls #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
91e7a07
add header with title and description
Maher-A-B Sep 18, 2025
d6eb349
test: add title and paragraph
Maher-A-B Sep 18, 2025
2ea8a6f
add header, 3 articles, and footer; style layout in CSS
Maher-A-B Sep 18, 2025
1a19b22
Complete Form Controls homework
Maher-A-B Oct 1, 2025
cc5c054
Fix label 'for' attribute and validation issues
Maher-A-B Oct 1, 2025
23fe97b
Total changes to the page according to the volunteer advice
Maher-A-B Oct 11, 2025
8712a75
Fix accessibility: add fieldset and legend for T-Shirt color radios
Maher-A-B Oct 11, 2025
cbe186f
Fix accessibility: add fieldset and legend for T-Shirt color radios
Maher-A-B Oct 11, 2025
cb37a8f
Resolve merge conflict: include accessibility fixes
Maher-A-B Oct 11, 2025
cd4438f
Delete Wireframe/index.html
Maher-A-B Oct 11, 2025
9d45d3d
Delete Wireframe/style.css
Maher-A-B Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 80 additions & 17 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,88 @@
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<title>My Form</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
<center>
<header>
<h1>Product Pick</h1>
</header>

<main>
<form>
<fieldset>
<legend align="center">Customer Information</legend>

<label for="name">Name:</label>
<input
type="text"
id="name"
name="name"
pattern="[A-Za-z\s]+"
title="Please enter a valid name (letters and spaces only)."
minlength="2"
required
/>
<br /><br />

<label for="email">Email:</label>
<input type="email" id="email" name="email" required />
<br /><br />
<label>T-Shirt Colour: </label>
Copy link

@tenzyns tenzyns Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the radio buttons could have their own fieldset or a div for accessibility and screen reader support?

<fieldset>
<legend align="center">T-Shirt Colour: </legend>
<br />
<input
type="radio"
id="white"
name="color"
value="white"
required
/>
<label for="white">White</label>

<br />
<input
type="radio"
id="black"
name="color"
value="black"
required
/>
<label for="black">Black</label>
<br />
<input
type="radio"
id="green"
name="color"
value="green"
required
/>
<label for="green">Green</label>
</fieldset>
<br /><br />
<label for="size">T-Shirt Size: </label>
<select id="size" name="size" required>
<option value="" disabled selected>-- Please Choose Size --</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
<br /><br />
<button type="submit">Submit Order</button>
</fieldset>
</form>
</main>

<footer>
<h2>By Maher Abou Albourgol - 2025 September Cohort - London</h2>
</footer>
</center>
</body>
</html>
</html>
33 changes: 0 additions & 33 deletions Wireframe/index.html
View file
Open in desktop

This file was deleted.

89 changes: 0 additions & 89 deletions Wireframe/style.css
View file
Open in desktop

This file was deleted.