generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 349
London | 25-ITP-September | Carlos Abreu | Sprint 2 | Form Controls #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carlosyabreu
wants to merge
11
commits into
CodeYourFuture:main
Choose a base branch
from
carlosyabreu:feature/form-controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
eef98f2
Add all the files of the project
carlosyabreu a517f26
Delete: index.html
carlosyabreu 8e682c9
Add form attributes for tshirt order form
carlosyabreu bf3b9dd
Add form elements for tshirt order form
carlosyabreu 36c7b82
Refactor the index.html adding accessibility and email validation
carlosyabreu 8f854aa
Correct accessibity to be 100%
carlosyabreu 80dfc2c
Revert "Add all the files of the project"
carlosyabreu 5e571cc
Add > operator to close label for email tag and pattern to validade o…
carlosyabreu 5c0f1c9
Add required for input text attribute
carlosyabreu 45816b5
Add required attribute for input email
carlosyabreu 5244c33
Run w3validator and fixed the wrong code
carlosyabreu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,58 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>T-Shirt Order Form</title> | ||
| </head> | ||
| <body> | ||
| <main> | ||
| <h1>T-Shirt Order Form</h1> | ||
| <p>Please provide your details and pick a colour and size. Only three colours are available.</p> | ||
|
|
||
| <form aria-labelledby="formTitle"> | ||
| <h2 id="formTitle" class="visually-hidden">Order form</h2> | ||
|
|
||
| <div> | ||
| <label for="customerName">Customer name</label> | ||
| <input type="text" id="customerName" name="customerName" pattern="[A-Za-z\s]+" required title="Alphabets and spaces only" placeholder="Full name" autocomplete="name"> | ||
| </div> | ||
| <br> | ||
|
|
||
| <div> | ||
| <label for="email">Email address</label> | ||
| <input type="email" id="email" name="email" placeholder="you@example.com" autocomplete="email" inputmode="email" aria-describedby="emailHelp" required> | ||
| <small id="emailHelp">Enter a valid email address (you@example.com).</small> | ||
| </div> | ||
| <br> | ||
|
|
||
| <fieldset> | ||
| <legend>Colour (choose one)</legend> | ||
| <label for="red"><input type="radio" id="red" name="colour" value="Red" required> Red</label> | ||
| <label for="blue"><input type="radio" id="blue" name="colour" value="Blue"> Blue</label> | ||
| <label for="green"><input type="radio" id="green" name="colour" value="Green"> Green</label> | ||
| </fieldset> | ||
| <br> | ||
|
|
||
| <div> | ||
| <label for="size">T-shirt size</label> | ||
| <select id="size" name="size" required> | ||
| <option value="">-- Select size --</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
| <br> | ||
|
|
||
| <div> | ||
| <button type="submit">Place order</button> | ||
| <button type="reset">Reset</button> | ||
| </div> | ||
| </form> | ||
| </main> | ||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep this footer and replace the placeholder text accordingly?