Skip to content

London | 25-ITP-September | Carlos Abreu | Sprint 2 | Form Controls #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
carlosyabreu wants to merge 11 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-September | Carlos Abreu | Sprint 2 | Form Controls #907

carlosyabreu wants to merge 11 commits into from

Conversation

@carlosyabreu
Copy link

@carlosyabreu carlosyabreu commented Oct 10, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

@jenny-alexander
This PR is about the Form-controls project that needs to be included into CYF main project.
I want to add I've deleted the repo you reviewed before, create a new repo because I made a mistake again merging my local feature/form-controls branch with my local main then I push to main GitHub branch.
After talking with another reviewer on #cyf-code-review channel I was advice not to merge in any circumstance my local branch (feature/form-controls) with local repo main branch.
Then I delete again the repo (2nd time) and started it clean (now 3rd time).
This repo is the last one and the one I want to be reviewed.
I add the deadline is today as I need it to be complete so I can apply for next stage called trainee.
Thank you for your understanding.

Questions

Hopefully this repo is the last one and PR is correct.
Please I need it ASAP today as today is my last time to apply for trainee.

@netlify
Copy link

netlify bot commented Oct 10, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 5244c33
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68ebcf45f7f34b00085f9700
😎 Deploy Preview https://deploy-preview-907--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 10, 2025
@carlosyabreu carlosyabreu changed the title Feature/form controls London | 25-ITP-September | Carlos Abreu | Sprint 2 | Form Controls Oct 10, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@carlosyabreu
Copy link
Author

carlosyabreu commented Oct 10, 2025

@jenny-alexander
I want to add the first time I opened this PR I forgot to change the title that's why it says (Your PR's title isn't in the expected format.)
I immediately correct the tile adding the correct format and now I think it's fine.
Thanks

@carlosyabreu carlosyabreu mentioned this pull request Oct 10, 2025
Closed
4 tasks
@carlosyabreu
Revert "Add all the files of the project"
80dfc2c 
This reverts commit eef98f2.

That was a done before I delete the remote GitHub repo and copied it to
local folder. After the new repo I copied the local folder files into
the new local repo. Accidentally copied the another projects as well
which should not be done as I want the project Form-Controls cleaned
without files and commits from Wireframe.
@cjyuan
Copy link
Contributor

cjyuan commented Oct 10, 2025

Please improve your PR and code according to the PR Guide first.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 10, 2025
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 11, 2025
@carlosyabreu
Copy link
Author

carlosyabreu commented Oct 11, 2025

@cjyuan and @LonMcGregor
I fixed the mistake and I think it's working as CYF requirement.

@cjyuan
Copy link
Contributor

cjyuan commented Oct 11, 2025

There are some errors in your HTML code. Can you fix them?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 11, 2025
@carlosyabreu
Copy link
Author

carlosyabreu commented Oct 12, 2025

@cjyuan
Thanks for the reply.
I fixed the errors in HTML code for email and username checks and I think it's fine now.
As well I fixed the check-boxes format making it more appropriate for Markdown style.
Once again thank you.

@LonMcGregor
I've been tagging @LonMcGregor as my first Form-Controls reviewers to no avail.
And the time is running out for the approval for Trainee phase.

@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2025
@carlosyabreu
Copy link
Author

carlosyabreu commented Oct 12, 2025

@cjyuan
I run the code on w3 validator and fixed the errors.
Thanks for pointing me to use w3 validator.
Now its free of errors.

cjyuan
cjyuan reviewed Oct 12, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form and code look good.

Can you restore the footer? I will mark this PR as complete first.

Form-Controls/index.html
Comment on lines -22 to -25
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
Copy link
Contributor

@cjyuan cjyuan Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep this footer and replace the placeholder text accordingly?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 12, 2025
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 12, 2025
This was referenced Oct 13, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlosyabreu @cjyuan