-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/fix path zrok #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- 【Performance】 - use web workers for sky projection calculations - implement LOD (level of detail) for sky map rendering - optimize data fetching with caching and timeouts - reduce bundle size with manual chunking - add performance monitor component - 【UI/UX】 - improve responsive design for filters drawer and map/table panels - add loading state for initial data loading - enhance sky map with zoom reset button - improve table with pagination and row selection - 【Refactor】 - refactor sky projection logic - memoize components and callbacks - use requestAnimationFrame for map drawing - 【Fix】 - fix table page size exceeding limit
- replace streamlit dashboard gif with new dashboard gif - update dashboard link to cosmoobs github page
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
- use inline worker script to avoid bundling issues - improve performance stats by removing async from measureRenderTime - fix DEC parallels calculation
- replace ngrok with zrok for improved tunneling - update minio endpoint url in notebooks and dashboard - add zrok interstitial bypass header for seamless access - implement dev proxy in vite config to inject headers and avoid cors issues - update cutout url construction for dev and production environments - remove ngrok-specific code and dependencies - update image loading logic to handle zrok redirects - update cutout card component to set alt attribute for accessibility
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Caution Review failedThe pull request is closed. WalkthroughEndpoints for MinIO/cutouts were switched from ngrok to zrok across README, dashboard code, and notebooks. Development now uses a Vite proxy for cutout requests, alters URL building and query params, and removes dev-only fetch/header logic. UI image attrs adjusted. Notebook kernel metadata and execution counts updated. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as Browser (Dashboard - DEV)
participant V as Vite Dev Server (Proxy)
participant Z as Zrok Host
participant S as Cutouts Service (/slcomp/Cutouts/*)
Note over U,V: New DEV flow via proxy
U->>V: GET /proxy-cutouts/{id}/{file}
V->>Z: Proxy request (rewrite to /slcomp/Cutouts/..., headers: skip_zrok_interstitial, UA)
Z->>S: Forward request
S-->>Z: 200 Image/Blob
Z-->>V: 200
V-->>U: 200 (image)
sequenceDiagram
autonumber
participant U as Browser (Dashboard - PROD)
participant R as RAW Endpoint (Zrok)
Note over U,R: Unchanged PROD flow (no proxy)
U->>R: GET https://.../Cutouts/{id}/{file}?skip_zrok_interstitial=true
R-->>U: 200 (image)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (8)
🔥 Files not summarized due to errors (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the service endpoint URL from a ngrok tunnel to a zrok tunnel, transitioning from "nonarithmetically-undeliberating-janelle.ngrok-free.app" to "l5s5a0sibv6w.share.zrok.io" across the codebase.
- Updates all MinIO endpoint URLs from ngrok to zrok tunneling service
- Adds zrok-specific proxy configuration and header handling for development
- Removes ngrok-specific code and replaces with zrok equivalents
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| notebooks/proposals/proposals.ipynb | Updates MinIO endpoint URL to zrok |
| notebooks/modified-gravity-tests/01_LaStBeRu_cosmo_ground.ipynb | Updates MinIO endpoint URL to zrok |
| notebooks/how_to.ipynb | Updates MinIO endpoint URL to zrok and execution metadata |
| notebooks/footprints/footprints.ipynb | Updates MinIO endpoint URL to zrok |
| dashboard/vite.config.ts | Adds zrok proxy configuration with bypass headers |
| dashboard/src/components/CutoutGrid.tsx | Replaces ngrok bypass parameter with zrok equivalent |
| dashboard/src/api.ts | Replaces ngrok-specific fetch logic with zrok proxy approach |
| README.md | Updates MinIO service link to zrok |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "outputs": [], | ||
| "source": [ | ||
| "MINIO_ENDPOINT_URL = \"nonarithmetically-undeliberating-janelle.ngrok-free.app\"\n", | ||
| "MINIO_ENDPOINT_URL = \"l5s5a0sibv6w.share.zrok.io\n", |
Copilot
AI
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing quote on the MINIO_ENDPOINT_URL string. The line should end with a closing double quote before the newline.
| "MINIO_ENDPOINT_URL = \"l5s5a0sibv6w.share.zrok.io\n", | |
| "MINIO_ENDPOINT_URL = \"l5s5a0sibv6w.share.zrok.io\"\n", |
| loading="lazy" | ||
| decoding="async" | ||
| crossOrigin="anonymous" | ||
| alt={record.band + ' cutout'} |
Copilot
AI
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The crossOrigin attribute was removed but this change appears unrelated to the zrok migration. The alt attribute addition is good for accessibility, but removing crossOrigin might cause CORS issues for direct image loading in production.
| alt={record.band + ' cutout'} | |
| alt={record.band + ' cutout'} | |
| crossOrigin="anonymous" |
Summary by CodeRabbit