Skip to content

Conversation

@oliveirara
Copy link
Contributor

@oliveirara oliveirara commented Sep 8, 2025

Summary by CodeRabbit

  • Documentation
    • Updated the Download Data link to the new MinIO service URL.
  • Bug Fixes
    • Improved cutout image loading by removing a cross-origin setting and updating the interstitial bypass parameter for more reliable access.
  • Chores
    • Switched raw data and notebook endpoints to a new host across the app and example notebooks.
    • Added a development-only proxy to streamline local testing of cutout images without CORS issues (no impact in production).

oliveirara and others added 8 commits September 8, 2025 11:49
- 【Performance】
- use web workers for sky projection calculations
- implement LOD (level of detail) for sky map rendering
- optimize data fetching with caching and timeouts
- reduce bundle size with manual chunking
- add performance monitor component
- 【UI/UX】
- improve responsive design for filters drawer and map/table panels
- add loading state for initial data loading
- enhance sky map with zoom reset button
- improve table with pagination and row selection
- 【Refactor】
- refactor sky projection logic
- memoize components and callbacks
- use requestAnimationFrame for map drawing
- 【Fix】
- fix table page size exceeding limit
- replace streamlit dashboard gif with new dashboard gif
- update dashboard link to cosmoobs github page
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
- use inline worker script to avoid bundling issues
- improve performance stats by removing async from measureRenderTime
- fix DEC parallels calculation
- replace ngrok with zrok for improved tunneling
- update minio endpoint url in notebooks and dashboard
- add zrok interstitial bypass header for seamless access
- implement dev proxy in vite config to inject headers and avoid cors issues
- update cutout url construction for dev and production environments
- remove ngrok-specific code and dependencies
- update image loading logic to handle zrok redirects
- update cutout card component to set alt attribute for accessibility
@oliveirara oliveirara self-assigned this Sep 8, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Caution

Review failed

The pull request is closed.

Walkthrough

Endpoints for MinIO/cutouts were switched from ngrok to zrok across README, dashboard code, and notebooks. Development now uses a Vite proxy for cutout requests, alters URL building and query params, and removes dev-only fetch/header logic. UI image attrs adjusted. Notebook kernel metadata and execution counts updated.

Changes

Cohort / File(s) Summary of Changes
Docs: MinIO link
README.md
Updated MinIO service link to https://3t611xfvhvp2.share.zrok.io.
Dashboard API: cutouts routing
dashboard/src/api.ts
Updated RAW endpoint host to zrok. In DEV, buildCutoutUrl returns /proxy-cutouts/... (stripping Cutouts/), enabling local proxy use. Removed ngrok header-fetch/blob fallback; DEV now returns proxied URL directly. Logging gated by VITE_DEBUG_CUTOUTS. PROD path construction unchanged.
Dashboard UI: image attrs and URL param
dashboard/src/components/CutoutGrid.tsx
Removed crossOrigin="anonymous". Added alt={record.band + ' cutout'}. Updated bypass param from ngrok-skip-browser-warning to skip_zrok_interstitial.
Dev server proxy: cutouts
dashboard/vite.config.ts
Added server.proxy['/proxy-cutouts'] targeting https://l5s5a0sibv6w.share.zrok.io, rewriting to /slcomp/Cutouts/..., and injecting headers skip_zrok_interstitial: true and a custom User-Agent. Updated CORS comment wording.
Notebooks: MINIO endpoint
notebooks/footprints/footprints.ipynb, notebooks/how_to.ipynb, notebooks/proposals/proposals.ipynb
Switched MINIO_ENDPOINT_URL to l5s5a0sibv6w.share.zrok.io (one notebook includes a trailing newline). No logic changes. how_to.ipynb also updated kernel metadata and execution counts.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as Browser (Dashboard - DEV)
  participant V as Vite Dev Server (Proxy)
  participant Z as Zrok Host
  participant S as Cutouts Service (/slcomp/Cutouts/*)

  Note over U,V: New DEV flow via proxy
  U->>V: GET /proxy-cutouts/{id}/{file}
  V->>Z: Proxy request (rewrite to /slcomp/Cutouts/..., headers: skip_zrok_interstitial, UA)
  Z->>S: Forward request
  S-->>Z: 200 Image/Blob
  Z-->>V: 200
  V-->>U: 200 (image)
Loading
sequenceDiagram
  autonumber
  participant U as Browser (Dashboard - PROD)
  participant R as RAW Endpoint (Zrok)

  Note over U,R: Unchanged PROD flow (no proxy)
  U->>R: GET https://.../Cutouts/{id}/{file}?skip_zrok_interstitial=true
  R-->>U: 200 (image)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

A rabbit hops through zrok-lit nights,
Sniffing new paths where cutout light bites.
Proxies burrow, headers in tow—
Images pop, swift as we go.
Goodbye ngrok, hello new warren—
Data flows smooth, carrots unburden. 🥕

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  - Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
  - Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6ef8c0 and cda2e8a.

📒 Files selected for processing (8)
  • README.md (1 hunks)
  • dashboard/src/api.ts (2 hunks)
  • dashboard/src/components/CutoutGrid.tsx (2 hunks)
  • dashboard/vite.config.ts (1 hunks)
  • notebooks/footprints/footprints.ipynb (1 hunks)
  • notebooks/how_to.ipynb (5 hunks)
  • notebooks/modified-gravity-tests/01_LaStBeRu_cosmo_ground.ipynb (1 hunks)
  • notebooks/proposals/proposals.ipynb (1 hunks)
🔥 Files not summarized due to errors (1)
  • notebooks/modified-gravity-tests/01_LaStBeRu_cosmo_ground.ipynb: Error: Server error: no LLM provider could handle the message
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/fix-path-zrok

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oliveirara oliveirara requested a review from Copilot September 8, 2025 20:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the service endpoint URL from a ngrok tunnel to a zrok tunnel, transitioning from "nonarithmetically-undeliberating-janelle.ngrok-free.app" to "l5s5a0sibv6w.share.zrok.io" across the codebase.

  • Updates all MinIO endpoint URLs from ngrok to zrok tunneling service
  • Adds zrok-specific proxy configuration and header handling for development
  • Removes ngrok-specific code and replaces with zrok equivalents

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
notebooks/proposals/proposals.ipynb Updates MinIO endpoint URL to zrok
notebooks/modified-gravity-tests/01_LaStBeRu_cosmo_ground.ipynb Updates MinIO endpoint URL to zrok
notebooks/how_to.ipynb Updates MinIO endpoint URL to zrok and execution metadata
notebooks/footprints/footprints.ipynb Updates MinIO endpoint URL to zrok
dashboard/vite.config.ts Adds zrok proxy configuration with bypass headers
dashboard/src/components/CutoutGrid.tsx Replaces ngrok bypass parameter with zrok equivalent
dashboard/src/api.ts Replaces ngrok-specific fetch logic with zrok proxy approach
README.md Updates MinIO service link to zrok

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"outputs": [],
"source": [
"MINIO_ENDPOINT_URL = \"nonarithmetically-undeliberating-janelle.ngrok-free.app\"\n",
"MINIO_ENDPOINT_URL = \"l5s5a0sibv6w.share.zrok.io\n",
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing quote on the MINIO_ENDPOINT_URL string. The line should end with a closing double quote before the newline.

Suggested change
"MINIO_ENDPOINT_URL = \"l5s5a0sibv6w.share.zrok.io\n",
"MINIO_ENDPOINT_URL = \"l5s5a0sibv6w.share.zrok.io\"\n",

Copilot uses AI. Check for mistakes.
loading="lazy"
decoding="async"
crossOrigin="anonymous"
alt={record.band + ' cutout'}
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crossOrigin attribute was removed but this change appears unrelated to the zrok migration. The alt attribute addition is good for accessibility, but removing crossOrigin might cause CORS issues for direct image loading in production.

Suggested change
alt={record.band + ' cutout'}
alt={record.band + ' cutout'}
crossOrigin="anonymous"

Copilot uses AI. Check for mistakes.
@oliveirara oliveirara merged commit 1b4e52a into main Sep 8, 2025
2 of 4 checks passed
@oliveirara oliveirara deleted the feat/fix-path-zrok branch September 8, 2025 20:41
@coderabbitai coderabbitai bot mentioned this pull request Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants